[test] Fix merging of test outcomes

tools/testrunner/local/testsuite_unittest.py

 #!/usr/bin/env python
 # Copyright 2016 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import sys
 import unittest
 
 # Needed because the test runner contains relative imports.
@@ skipping 25 matching lines @@
     }
     suite.FilterTestCasesByStatus(warn_unused_rules=False)
     self.assertEquals(
         [TestCase(suite, 'baz/bar')],
         suite.tests,
     )
     self.assertEquals(set(['PASS', 'FAIL', 'SLOW']), suite.tests[0].outcomes)
 
   def test_filter_testcases_by_status_second_pass(self):
     suite = TestSuite('foo', 'bar')
-    suite.tests = [
-      TestCase(suite, 'foo/bar', variant='default'),
-      TestCase(suite, 'foo/bar', variant='stress', flags=['-v']),
-      TestCase(suite, 'baz/bar', variant='default'),
-      TestCase(suite, 'baz/bar', variant='stress', flags=['-v']),
-    ]
+
+    test1 = TestCase(suite, 'foo/bar')
+    test2 = TestCase(suite, 'baz/bar')
 
     # Contrived outcomes from filtering by variant-independent rules.
-    suite.tests[0].outcomes = set(['PREV'])
-    suite.tests[1].outcomes = set(['PREV'])
-    suite.tests[2].outcomes = set(['PREV'])
-    suite.tests[3].outcomes = set(['PREV'])
+    test1.outcomes = set(['PREV'])
+    test2.outcomes = set(['PREV'])
+
+    suite.tests = [

[Michael Achenbach, 2016/08/05 09:02:41]

Btw: This test change reveals the problem.

+      test1.CopyAddingFlags(variant='default', flags=[]),
+      test1.CopyAddingFlags(variant='stress', flags=['-v']),
+      test2.CopyAddingFlags(variant='default', flags=[]),
+      test2.CopyAddingFlags(variant='stress', flags=['-v']),
+    ]
 
     suite.rules = {
       'default': {
         'foo/bar': set(['PASS', 'SKIP']),
         'baz/bar': set(['PASS', 'FAIL']),
       },
       'stress': {
         'baz/bar': set(['SKIP']),
       },
     }
@@ skipping 19 matching lines @@
         suite.tests[0].outcomes,
     )
     self.assertEquals(
         set(['PASS', 'FAIL', 'SLOW', 'PREV']),
         suite.tests[1].outcomes,
     )
 
 
 if __name__ == '__main__':
     unittest.main()