Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2215933002: Migrate remaining tests on chromium.gpu.fyi to Swarming. (Closed)

Created:
4 years, 4 months ago by M-A Ruel
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@5_do_all
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate remaining tests on chromium.gpu.fyi to Swarming. This means the testers do not need to be hardware based anymore. R=kbr@chromium.org BUG=98637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M testing/buildbot/chromium.gpu.fyi.json View 8 chunks +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (0 generated)
M-A Ruel
4 years, 4 months ago (2016-08-04 17:55:05 UTC) #1
Ken Russell (switch to Gerrit)
not lgtm I'm not sure of the motivation for this CL, but all of the ...
4 years, 4 months ago (2016-08-05 01:11:06 UTC) #2
M-A Ruel
On 2016/08/05 01:11:06, Ken Russell wrote: > not lgtm > > I'm not sure of ...
4 years, 4 months ago (2016-08-05 14:15:17 UTC) #3
Ken Russell (switch to Gerrit)
4 years, 4 months ago (2016-08-05 19:17:58 UTC) #4
Message was sent while issue was closed.
On 2016/08/05 14:15:17, M-A Ruel wrote:
> On 2016/08/05 01:11:06, Ken Russell wrote:
> > not lgtm
> > 
> > I'm not sure of the motivation for this CL
> 
> With the migration off buildbot, all builds will be driven by a recipe that
> doesn't have access to the checkout, so all tests will have to be isolated one
> day or another, or you'll be stuck in a one-off configuration.
> 
> Anyhow, there's no hurry a the moment, closing.

This test target is already isolated. It wouldn't be a problem to invoke the
test locally via that isolate.



> 
> > , but all of the tests that can be
> > swarmed on the chromium.gpu.fyi waterfall already are. It looks like this CL
> > changes this flag for some of the remaining physical testers on this
waterfall
> > which will never be converted to Swarming because we don't want to purchase
> > multiple machines of their kind.
> > 
> > If the intent here is to change the tests' specifications to all have
> > "can_use_on_swarming_builders" set to true, that should be done in
> > src/content/test/gpu/generate_buildbot_json.py even for the (one entry in)
> > NON_SWARMED_GTESTS, and presumably, the fact that Swarming is disabled for
> these
> > machines in
> > tools/build/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
> will
> > take precedence.

Powered by Google App Engine
This is Rietveld 408576698