Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2217583002:
Migrate the majority of tests on chromium.fyi to run on Swarming. (Closed)
DescriptionMigrate the majority of tests on chromium.fyi to run on Swarming.
R=thakis@chromium.org
BUG=98637
Committed: https://crrev.com/60911e126c9bda7928d774bf1697fa07972cfd58
Cr-Commit-Position: refs/heads/master@{#410092}
Patch Set 1 #
Total comments: 15
Patch Set 2 : Reduce the number of converted tests #
Total comments: 3
Patch Set 3 : Skip Android Tests trial dbg #
Depends on Patchset: Messages
Total messages: 15 (5 generated)
There's two categories of changes: - one of tests that were forgotten but otherwise most of the tests on the builder were already running on Swarming - builders with no test running on swarming at all The later will likely break with this change. It could be worth splitting it up but on the other hand, we can just commit this change and revert only for the builders that broke. I don't monitor any builder on FYI so I don't have any opinion.
I agree the type 2 bots shouldn't be swarmed https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:2: "Android Asan Builder Tests (dbg)": { this bot shouldn't be swarmed https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:1675: "Chromium Mac 10.10 MacViews": { this bot shouldn't be swarmed (swarming doesn't guarantee 10.10) https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:1937: "Chromium Mac 10.11": { likewise https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:2239: "Chromium Mac 10.11 Force Mac Toolchain": { likewise https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:9173: "Headless Linux (dbg)": { this one shouldn't be swarmed either i think https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10951: "Mojo ChromiumOS": { ditto https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10994: "Mojo Windows": { ditto
https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:2: "Android Asan Builder Tests (dbg)": { On 2016/08/04 18:39:51, Nico wrote: > this bot shouldn't be swarmed Done. https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:1675: "Chromium Mac 10.10 MacViews": { On 2016/08/04 18:39:51, Nico wrote: > this bot shouldn't be swarmed (swarming doesn't guarantee 10.10) Done. There's 149x 10.10 bots https://chromium-swarm.appspot.com/restricted/bots?dimensions=os%3AMac-10.10&... This builder is very sad: https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.10%20M... https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:1828: "swarming": { Removed these. https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:1937: "Chromium Mac 10.11": { On 2016/08/04 18:39:51, Nico wrote: > likewise Done. There's 10x 10.11 bots https://chromium-swarm.appspot.com/restricted/bots?dimensions=os%3AMac-10.11 The builder is very sad https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.11 https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:2239: "Chromium Mac 10.11 Force Mac Toolchain": { On 2016/08/04 18:39:51, Nico wrote: > likewise Done. https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:9173: "Headless Linux (dbg)": { On 2016/08/04 18:39:51, Nico wrote: > this one shouldn't be swarmed either i think I wonder why this is a fyi bot and not have the test be moved to the normal builders. https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10951: "Mojo ChromiumOS": { On 2016/08/04 18:39:51, Nico wrote: > ditto Are you sure about these two? Done anyhow and we can look at it later. https://codereview.chromium.org/2217583002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10994: "Mojo Windows": { On 2016/08/04 18:39:51, Nico wrote: > ditto Done. https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:704: "swarming": { Maybe not this one (?)
lgtm with comment Thanks much! https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:704: "swarming": { On 2016/08/04 18:52:59, M-A Ruel wrote: > Maybe not this one (?) Yes, probably not.
https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2217583002/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:704: "swarming": { On 2016/08/04 18:55:58, Nico wrote: > On 2016/08/04 18:52:59, M-A Ruel wrote: > > Maybe not this one (?) > > Yes, probably not. Done.
The CQ bit was checked by maruel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2217583002/#ps40001 (title: "Skip Android Tests trial dbg")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Migrate the majority of tests on chromium.fyi to run on Swarming. R=thakis@chromium.org BUG=98637 ========== to ========== Migrate the majority of tests on chromium.fyi to run on Swarming. R=thakis@chromium.org BUG=98637 Committed: https://crrev.com/60911e126c9bda7928d774bf1697fa07972cfd58 Cr-Commit-Position: refs/heads/master@{#410092} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/60911e126c9bda7928d774bf1697fa07972cfd58 Cr-Commit-Position: refs/heads/master@{#410092} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
