swarming: wholesale switch remaining tests to run on Swarming.

swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/44522885bce6672a1023498adf75d06d07cbe0ac
Cr-Commit-Position: refs/heads/master@{#409829}

[M-A Ruel, 2016-08-02 18:12:10]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 18:19:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[M-A Ruel, 2016-08-02 18:44:24]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-02 18:55:05]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:55:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-02 19:04:04]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

R=dpranke@chromium.org
BUG=98637
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining test run locally is nacl_integration.

R=dpranke@chromium.org
BUG=98637
==========

[M-A Ruel, 2016-08-02 19:18:43]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2016-08-02 19:19:01]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining test run locally is nacl_integration.

R=dpranke@chromium.org
BUG=98637
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining test run locally on non-blink testers is
nacl_integration.

R=dpranke@chromium.org
BUG=98637
==========

[M-A Ruel, 2016-08-02 19:22:07]

Patchset #1 (id:20001) has been deleted

[M-A Ruel, 2016-08-02 19:22:57]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining test run locally on non-blink testers is
nacl_integration.

R=dpranke@chromium.org
BUG=98637
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org
BUG=98637
==========

[commit-bot: I haz the power, 2016-08-02 19:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:36:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[M-A Ruel, 2016-08-02 19:49:21]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:39:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:39:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[M-A Ruel, 2016-08-03 17:44:49]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org
BUG=98637
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 17:47:28]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 17:47:28]

maruel@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[M-A Ruel, 2016-08-03 17:47:47]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[M-A Ruel, 2016-08-03 17:47:58]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-03 17:48:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-03 17:53:05]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6
  # Update BUILD.gn
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 18:07:51]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6
  # Update BUILD.gn
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 18:10:25]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:10:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-03 18:26:29]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-03 18:43:22]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-08-03 19:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:27:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[M-A Ruel, 2016-08-03 19:28:40]

Patchset #1 (id:80001) has been deleted

[M-A Ruel, 2016-08-03 19:29:05]

Patchset #1 (id:100001) has been deleted

[M-A Ruel, 2016-08-03 19:32:26]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[M-A Ruel, 2016-08-03 19:33:07]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 19:33:08]

maruel@chromium.org changed reviewers:
+ derat@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-08-03 19:35:18]

lgtm

[M-A Ruel, 2016-08-03 19:38:50]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[M-A Ruel, 2016-08-03 19:38:59]

On 2016/08/03 19:35:18, dmazzoni wrote:
> lgtm

FTR, I hadn't published the CL yet, still waiting to get mash_browser_tests
fixed. That said, I'm done with chromevox_tests so this is good.

[commit-bot: I haz the power, 2016-08-03 19:39:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-08-03 20:21:14]

lgtm for ui/chromeos/

[commit-bot: I haz the power, 2016-08-03 20:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:58:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[M-A Ruel, 2016-08-03 22:32:53]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 22:33:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-03 22:33:44]

lgtm

https://codereview.chromium.org/2202393002/diff/160001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2202393002/diff/160001/tools/mb/mb.py#newcode...
tools/mb/mb.py:1062: cmdline.extend(('--gtest_filter=%s' % gtest_filter))
ick. I'm surprised this didn't cause more problems.

[M-A Ruel, 2016-08-03 22:36:13]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org,oshima@chromi...
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-03 22:36:14]

maruel@chromium.org changed reviewers:
+ oshima@chromium.org

[M-A Ruel, 2016-08-03 22:37:59]

+Mitsuru

Still having trouble to get mash_browser_tests to work.

https://codereview.chromium.org/2202393002/diff/160001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2202393002/diff/160001/tools/mb/mb.py#newcode...
tools/mb/mb.py:1062: cmdline.extend(('--gtest_filter=%s' % gtest_filter))
On 2016/08/03 22:33:44, Dirk Pranke wrote:
> ick. I'm surprised this didn't cause more problems.

This was broken, fixed in patchset 4.

[M-A Ruel, 2016-08-03 23:06:53]

On 2016/08/03 22:37:59, M-A Ruel wrote:
> +Mitsuru
> 
> Still having trouble to get mash_browser_tests to work.

In particular, I'm not able to get it to run locally;

testing/test_env.py out/Cros_Release/browser_tests --brave-new-test-launcher
--test-launcher-bot-mode --override-use-gl-with-osmesa-for-tests --run-in-mash
--test-launcher-filter-file=testing/buildbot/filters/mash.browser_tests.filter
--use-test-config --test-launcher-summary-output=output.json

completely fails with crashes on a chromium for chromiumos build:
[0803/190306:ERROR:wm_shell_mus.cc(262)] Not implemented reached in virtual void
ash::mus::WmShellMus::RecordUserMetricsAction(ash::UserMetricsAction)
[0803/190306:ERROR:shell_delegate_mus.cc(195)] Not implemented reached in
virtual ash::MediaDelegate *ash::ShellDelegateMus::CreateMediaDelegate() Using a
stub MediaDe
legate implementation

Mitsuru, how am I supposed to run this test locally?

I'm doing this to be nice to the abandoned tests but these need to be isolated
asap or I'll remove them from the CI.

Thanks

[commit-bot: I haz the power, 2016-08-03 23:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 23:40:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-08-04 01:24:09]

oshima@chromium.org changed reviewers:
+ sky@chromium.org
- oshima@chromium.org

[oshima, 2016-08-04 01:25:16]

I'm not working on mash. -> sky@

[sky, 2016-08-04 15:56:43]

On 2016/08/03 23:06:53, M-A Ruel wrote:
> On 2016/08/03 22:37:59, M-A Ruel wrote:
> > +Mitsuru
> > 
> > Still having trouble to get mash_browser_tests to work.
> 
> In particular, I'm not able to get it to run locally;
> 
> testing/test_env.py out/Cros_Release/browser_tests --brave-new-test-launcher
> --test-launcher-bot-mode --override-use-gl-with-osmesa-for-tests --run-in-mash
> --test-launcher-filter-file=testing/buildbot/filters/mash.browser_tests.filter
> --use-test-config --test-launcher-summary-output=output.json
> 
> completely fails with crashes on a chromium for chromiumos build:
> [0803/190306:ERROR:wm_shell_mus.cc(262)] Not implemented reached in virtual
void
> ash::mus::WmShellMus::RecordUserMetricsAction(ash::UserMetricsAction)
> [0803/190306:ERROR:shell_delegate_mus.cc(195)] Not implemented reached in
> virtual ash::MediaDelegate *ash::ShellDelegateMus::CreateMediaDelegate() Using
a
> stub MediaDe
> legate implementation
> 
> Mitsuru, how am I supposed to run this test locally?

Did you use the same gn flags as the bots do for the build? The error output you
pasted is NOTIMPLEMENTEDs, which shouldn't be fatal.

[M-A Ruel, 2016-08-04 16:24:01]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 16:24:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-04 16:25:24]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are nacl_integration and test_installer.

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org,oshima@chromi...
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org,oshima@chromi...
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[M-A Ruel, 2016-08-04 16:28:18]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 16:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-04 16:29:55]

The CQ bit was checked by maruel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 16:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-04 16:30:33]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org,oshima@chromi...
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-04 17:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:37:49]

Dry run: This issue passed the CQ dry run.

[M-A Ruel, 2016-08-04 17:54:12]

On 2016/08/04 15:56:43, sky wrote:
> Did you use the same gn flags as the bots do for the build? The error output
you
> pasted is NOTIMPLEMENTEDs, which shouldn't be fatal.

I trimmed down this CL to reduce the risk of revert, and will postpone
mash_browser_tests into its own CL so other owners are not spammed with
unnecessary messages. Will send follow up CLs shortly; one for fyi, one for
gpu.fyi and another for mash_browser_tests.

[M-A Ruel, 2016-08-04 17:54:22]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2016-08-04 17:54:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, derat@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2202393002/#ps240001
(title: "No need to modify mb.py")

[commit-bot: I haz the power, 2016-08-04 17:54:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:59:29]

Committed patchset #7 (id:240001)

[commit-bot: I haz the power, 2016-08-04 18:01:44]

Description was changed from

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
swarming: wholesale switch remaining tests to run on Swarming.

Since the switch to GN and no need to support GYP, it's easier to migrate the
remaining tests.

With this change in, the only remaining tests run locally on non-blink testers
are:
- Many FYI and GPU bots.
- blimp_browsertests
- mash_browser_tests
- nacl_integration
- test_installer

- Remove dbus_unittests from Ozone builders since this test depends on X.
- Fix chromevox_tests dependencies in BUILD.gn.

The technique used to figure out the runtime dependencies was to first run a
test case under //tools/swarming_client/trace_inputs.py and confirming with
'mb.py run', approximatively:
  # Builds the executable and the .isolate
  tools/mb/mb.py run //out/Cros_Release -j 500 -m chromium.chromiumos \
      -b "Linux ChromiumOS GN" chromevox_tests
  # Look at actual runtime dependencies.
  tools/swarming_client/trace_inputs.py trace -l foo6 testing/test_env.py \
      out/Cros_Release/chromevox_tests \
      --gtest_filter=CvoxDomUtilUnitTest.Tree --no-sandbox
  tools/swarming_client/trace_inputs.py read  -l foo6 --root-dir .
  # Compare with the output dependencies as stated by BUILD.gn
  cat out/Cros_Release/chromevox_tests.isolate
  # Then update BUILD.gn accordingly.

R=dpranke@chromium.org,dmazzoni@chromium.org,derat@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/44522885bce6672a1023498adf75d06d07cbe0ac
Cr-Commit-Position: refs/heads/master@{#409829}
==========

[commit-bot: I haz the power, 2016-08-04 18:01:46]

Patchset 7 (id:??) landed as
https://crrev.com/44522885bce6672a1023498adf75d06d07cbe0ac
Cr-Commit-Position: refs/heads/master@{#409829}

[Nico, 2016-08-04 18:03:54]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-08-04 18:03:55]

Can you do the same for all the clang bots on chromium.fyi too?