Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2215183003: [turbofan] Move lowering of Float64 optional operators to EffectControlLinearizer. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move lowering of Float64 optional operators to EffectControlLinearizer. It's just a refactoring to avoid introducing new floating controls in the SimplifiedLowering phase. R=bmeurer@chromium.org Committed: https://crrev.com/46eba4548589bc9b987bf35d15d1cfd64297a16c Cr-Commit-Position: refs/heads/master@{#38365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -395 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +393 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 6 chunks +6 lines, -392 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
epertoso
4 years, 4 months ago (2016-08-05 08:58:32 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/2215183003/diff/20001/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2215183003/diff/20001/src/compiler/simplified-lowering.cc#newcode2931 src/compiler/simplified-lowering.cc:2931: return graph()->NewNode(machine()->Float64RoundUp().placeholder(), Nit: Can you remove the helper functions ...
4 years, 4 months ago (2016-08-05 09:00:26 UTC) #5
epertoso
https://codereview.chromium.org/2215183003/diff/20001/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2215183003/diff/20001/src/compiler/simplified-lowering.cc#newcode2931 src/compiler/simplified-lowering.cc:2931: return graph()->NewNode(machine()->Float64RoundUp().placeholder(), On 2016/08/05 09:00:26, Benedikt Meurer wrote: > ...
4 years, 4 months ago (2016-08-05 09:42:26 UTC) #6
Benedikt Meurer
Awesome, thanks. LGTM.
4 years, 4 months ago (2016-08-05 09:43:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215183003/40001
4 years, 4 months ago (2016-08-05 09:44:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-05 10:05:55 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 10:06:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46eba4548589bc9b987bf35d15d1cfd64297a16c
Cr-Commit-Position: refs/heads/master@{#38365}

Powered by Google App Engine
This is Rietveld 408576698