Return v8::Date specialization not v8::Value where possible

Return v8::Date specialization not v8::Value where possible

Also get rid of FXJS_ValueCopy() while we're at it.

BUG=pdfium:556
Committed: https://pdfium.googlesource.com/pdfium/+/135b99861d0d898850754a845f607ec48f0bcccc

[Tom Sepez, 2016-08-04 22:08:27]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org

[Tom Sepez, 2016-08-04 22:08:28]

Jochen, for review, some small cleanup.

[Tom Sepez, 2016-08-04 22:08:38]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 22:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:20:12]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-04 22:29:55]

Description was changed from

==========
Return v8::Date specialization not v8::Value where possible
==========

to

==========
Return v8::Date specialization not v8::Value where possible

Also get rid of FXJS_ValueCopy() while we're at it.

BUG=pdfium:556
==========

[Tom Sepez, 2016-08-04 23:34:09]

https://codereview.chromium.org/2215093002/diff/20001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.cpp (right):

https://codereview.chromium.org/2215093002/diff/20001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:256: date.Attach(mutable_value.As<v8::Date>());
note: As<> missing const.  Should it be?

[jochen (gone - plz use gerrit), 2016-08-05 11:50:32]

lgtm

https://codereview.chromium.org/2215093002/diff/20001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.cpp (right):

https://codereview.chromium.org/2215093002/diff/20001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:256: date.Attach(mutable_value.As<v8::Date>());
On 2016/08/04 at 23:34:08, Tom Sepez wrote:
> note: As<> missing const.  Should it be?

yeah, should probably be const

[Tom Sepez, 2016-08-05 16:16:55]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:17:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 16:32:58]

Description was changed from

==========
Return v8::Date specialization not v8::Value where possible

Also get rid of FXJS_ValueCopy() while we're at it.

BUG=pdfium:556
==========

to

==========
Return v8::Date specialization not v8::Value where possible

Also get rid of FXJS_ValueCopy() while we're at it.

BUG=pdfium:556

Committed:
https://pdfium.googlesource.com/pdfium/+/135b99861d0d898850754a845f607ec48f0b...
==========

[commit-bot: I haz the power, 2016-08-05 16:33:01]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/135b99861d0d898850754a845f607ec48f0b...