Return v8::Date specialization not v8::Value where possible

fpdfsdk/javascript/JS_Value.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/javascript/JS_Value.h"
 
 #include <time.h>
 
@@ skipping 234 matching lines @@
   if (IsArrayObject()) {
     array.Attach(FXJS_ToArray(m_pJSRuntime->GetIsolate(), m_pValue));
     return TRUE;
   }
 
   return FALSE;
 }
 
 FX_BOOL CJS_Value::ConvertToDate(CJS_Date& date) const {
   if (IsDateObject()) {
-    date.Attach(m_pValue);
+    v8::Local<v8::Value> mutable_value = m_pValue;
+    date.Attach(mutable_value.As<v8::Date>());

[Tom Sepez, 2016/08/04 23:34:08]

note: As<> missing const.  Should it be?

[jochen (gone - plz use gerrit), 2016/08/05 11:50:32]

yeah, should probably be const

     return TRUE;
   }
 
   return FALSE;
 }
 
 CJS_PropValue::CJS_PropValue(const CJS_Value& value)
     : CJS_Value(value), m_bIsSetting(0) {}
 
 CJS_PropValue::CJS_PropValue(CJS_Runtime* pRuntime)
@@ skipping 164 matching lines @@
                          MakeDate(year, mon, day, hour, min, sec, 0));
 }
 
 CJS_Date::~CJS_Date() {}
 
 bool CJS_Date::IsValidDate() const {
   return !m_pDate.IsEmpty() &&
          !JS_PortIsNan(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate));
 }
 
-void CJS_Date::Attach(v8::Local<v8::Value> pDate) {
+void CJS_Date::Attach(v8::Local<v8::Date> pDate) {
   m_pDate = pDate;
 }
 
 int CJS_Date::GetYear() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetYearFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetYear(int iYear) {
   double date = MakeDate(iYear, GetMonth(), GetDay(), GetHours(), GetMinutes(),
                          GetSeconds(), 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 int CJS_Date::GetMonth() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetMonthFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetMonth(int iMonth) {
   double date = MakeDate(GetYear(), iMonth, GetDay(), GetHours(), GetMinutes(),
                          GetSeconds(), 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 int CJS_Date::GetDay() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetDayFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetDay(int iDay) {
   double date = MakeDate(GetYear(), GetMonth(), iDay, GetHours(), GetMinutes(),
                          GetSeconds(), 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 int CJS_Date::GetHours() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetHourFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetHours(int iHours) {
   double date = MakeDate(GetYear(), GetMonth(), GetDay(), iHours, GetMinutes(),
                          GetSeconds(), 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 int CJS_Date::GetMinutes() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetMinFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetMinutes(int minutes) {
   double date = MakeDate(GetYear(), GetMonth(), GetDay(), GetHours(), minutes,
                          GetSeconds(), 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 int CJS_Date::GetSeconds() const {
   if (!IsValidDate())
     return 0;
 
   return JS_GetSecFromTime(
       JS_LocalTime(FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate)));
 }
 
 void CJS_Date::SetSeconds(int seconds) {
   double date = MakeDate(GetYear(), GetMonth(), GetDay(), GetHours(),
                          GetMinutes(), seconds, 0);
-  FXJS_ValueCopy(m_pDate, FXJS_NewDate(m_pJSRuntime->GetIsolate(), date));
+  m_pDate = FXJS_NewDate(m_pJSRuntime->GetIsolate(), date);
 }
 
 double CJS_Date::ToDouble() const {
   if (m_pDate.IsEmpty())
     return 0.0;
 
   return FXJS_ToNumber(m_pJSRuntime->GetIsolate(), m_pDate);
 }
 
 CFX_WideString CJS_Date::ToString() const {
@@ skipping 307 matching lines @@
   for (size_t i = 0; i < nKeywords; ++i) {
     const wchar_t* property = va_arg(ap, const wchar_t*);
     v8::Local<v8::Value> v8Value =
         FXJS_GetObjectElement(pRuntime->GetIsolate(), pObj, property);
     if (!v8Value->IsUndefined())
       result[i] = CJS_Value(pRuntime, v8Value);
   }
   va_end(ap);
   return result;
 }