fpdfsdk/javascript/JS_Value.h - Issue 2215093002: Return v8::Date specialization not v8::Value where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Value.h

Issue 2215093002: Return v8::Date specialization not v8::Value where possible (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: remove fxjs_valuecopy Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/JS_Value.h

diff --git a/fpdfsdk/javascript/JS_Value.h b/fpdfsdk/javascript/JS_Value.h

index 5943aaf888e0cf72c4c51de8c052ae10bd8579ef..01b4e5ba4537337716d7b350836f014fb8f1e17d 100644

--- a/fpdfsdk/javascript/JS_Value.h

+++ b/fpdfsdk/javascript/JS_Value.h

@@ -159,7 +159,7 @@ class CJS_Date {

int sec);

virtual ~CJS_Date();

- void Attach(v8::Local<v8::Value> pDate);

+ void Attach(v8::Local<v8::Date> pDate);

bool IsValidDate() const;

int GetYear() const;

@@ -186,7 +186,7 @@ class CJS_Date {

CFX_WideString ToString() const;

protected:

- v8::Local<v8::Value> m_pDate;

+ v8::Local<v8::Date> m_pDate;

CJS_Runtime* const m_pJSRuntime;

};

« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Value.cpp » ('j') | fpdfsdk/javascript/JS_Value.cpp » ('J')