Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 221423003: rebaseline_server: display as much info as possible if expected/actual image is missing (Closed)

Created:
6 years, 8 months ago by epoger
Modified:
6 years, 8 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: display as much info as possible if expected/actual image is missing BUG=skia:2368 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14019

Patch Set 1 #

Patch Set 2 : remove extra import #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -23 lines) Patch
M gm/rebaseline_server/imagediffdb.py View 1 chunk +8 lines, -2 lines 0 comments Download
M gm/rebaseline_server/imagepair.py View 1 4 chunks +6 lines, -3 lines 0 comments Download
M gm/rebaseline_server/imagepair_test.py View 1 chunk +30 lines, -0 lines 0 comments Download
M gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json View 8 chunks +8 lines, -8 lines 1 comment Download
M gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Ready for review at patchset 2. And you can see it in action at http://172.24.179.183:8888/ ...
6 years, 8 months ago (2014-04-01 20:39:35 UTC) #1
borenet
LGTM https://codereview.chromium.org/221423003/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json File gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json (right): https://codereview.chromium.org/221423003/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json#newcode1 gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json:1: { I have no idea what these files ...
6 years, 8 months ago (2014-04-01 21:15:56 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-01 21:23:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/221423003/20001
6 years, 8 months ago (2014-04-01 21:34:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/221423003/20001
6 years, 8 months ago (2014-04-01 21:54:37 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 22:16:56 UTC) #6
Message was sent while issue was closed.
Change committed as 14019

Powered by Google App Engine
This is Rietveld 408576698