gm/rebaseline_server/imagediffdb.py - Issue 221423003: rebaseline_server: display as much info as possible if expected/actual image is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/imagediffdb.py

Issue 221423003: rebaseline_server: display as much info as possible if expected/actual image is missing (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: remove extra import Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | gm/rebaseline_server/imagepair.py » ('j') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/rebaseline_server/imagediffdb.py

diff --git a/gm/rebaseline_server/imagediffdb.py b/gm/rebaseline_server/imagediffdb.py

index 8328543c935d77bbdc011701d85356c78fe9270f..3b1eb3ebc032a804b444c453dd28f9ed4cc06307 100644

--- a/gm/rebaseline_server/imagediffdb.py

+++ b/gm/rebaseline_server/imagediffdb.py

@@ -268,8 +268,14 @@ class ImageDiffDB(object):

actual_image_url=actual_image_url,

actual_image_locator=actual_image_locator)

except Exception:

- logging.exception('got exception while creating new DiffRecord')

- return

+ # If we can't create a real DiffRecord for this (expected, actual) pair,

+ # store None and the UI will show whatever information we DO have.

+ # Fixes http://skbug.com/2368 .

+ logging.exception(

+ 'got exception while creating a DiffRecord for '

+ 'expected_image_url=%s , actual_image_url=%s; returning None' % (

+ expected_image_url, actual_image_url))

+ new_diff_record = None

self._diff_dict[key] = new_diff_record

def get_diff_record(self, expected_image_locator, actual_image_locator):