Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: gm/rebaseline_server/imagepair_test.py

Issue 221423003: rebaseline_server: display as much info as possible if expected/actual image is missing (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove extra import Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/imagepair_test.py
diff --git a/gm/rebaseline_server/imagepair_test.py b/gm/rebaseline_server/imagepair_test.py
index b2cae31a51d983a6011248c38bd2c3f2f7835911..95b7e4d44d2a7421415fff9e04455026f479f68e 100755
--- a/gm/rebaseline_server/imagepair_test.py
+++ b/gm/rebaseline_server/imagepair_test.py
@@ -132,6 +132,36 @@ class ImagePairTest(unittest.TestCase):
'isDifferent': True,
},
],
+
+ # Test fix for http://skbug.com/2368 -- how do we handle an ImagePair
+ # missing one of its images?
+ [
+ # inputs:
+ 'arcofzorro/16206093933823793653.png',
+ 'nonexistentDir/111111.png',
+ {
+ 'ignoreFailure': True,
+ 'bugs': [1001, 1002],
+ },
+ {
+ 'builder': 'MyBuilder',
+ 'test': 'MyTest',
+ },
+ # expected output:
+ {
+ 'expectations': {
+ 'bugs': [1001, 1002],
+ 'ignoreFailure': True,
+ },
+ 'extraColumns': {
+ 'builder': 'MyBuilder',
+ 'test': 'MyTest',
+ },
+ 'imageAUrl': 'arcofzorro/16206093933823793653.png',
+ 'imageBUrl': 'nonexistentDir/111111.png',
+ 'isDifferent': True,
+ },
+ ],
]
db = imagediffdb.ImageDiffDB(self._temp_dir)

Powered by Google App Engine
This is Rietveld 408576698