base/metrics/field_trial_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/field_trial_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/field_trial_unittest.cc

diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc

index fd3d4ac90c0a65ad08f7337030ec85f95ca0ef4d..bcfc3a9dbed4d76b49dd18d3e9223d9cb27c17e4 100644

--- a/base/metrics/field_trial_unittest.cc

+++ b/base/metrics/field_trial_unittest.cc

@@ -1128,8 +1128,7 @@ TEST(FieldTrialDeathTest, OneTimeRandomizedTrialWithoutFieldTrialList) {

FieldTrialList::FactoryGetFieldTrial(

"OneTimeRandomizedTrialWithoutFieldTrialList", 100, kDefaultGroupName,

base::FieldTrialList::kNoExpirationYear, 1, 1,

- base::FieldTrial::ONE_TIME_RANDOMIZED, NULL),

- "");

+ base::FieldTrial::ONE_TIME_RANDOMIZED, NULL));

}

} // namespace base

« no previous file with comments | « base/message_loop/message_pump_libevent_unittest.cc ('k') | base/metrics/histogram_unittest.cc » ('j') | no next file with comments »