Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: base/message_loop/message_pump_libevent_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable
Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump_io_ios_unittest.cc ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_libevent_unittest.cc
diff --git a/base/message_loop/message_pump_libevent_unittest.cc b/base/message_loop/message_pump_libevent_unittest.cc
index b4b946e59469f225d370a6a64baa7b2fb9a98e3c..4164b3a7e49ff8e4971d62c07874a648d8f06fd2 100644
--- a/base/message_loop/message_pump_libevent_unittest.cc
+++ b/base/message_loop/message_pump_libevent_unittest.cc
@@ -93,16 +93,12 @@ TEST_F(MessagePumpLibeventTest, MAYBE_TestWatchingFromBadThread) {
ASSERT_DCHECK_DEATH(
io_loop()->WatchFileDescriptor(STDOUT_FILENO, false,
MessageLoopForIO::WATCH_READ, &watcher,
- &delegate),
- "Check failed: "
- "watch_file_descriptor_caller_checker_.CalledOnValidThread\\(\\)");
+ &delegate));
}
TEST_F(MessagePumpLibeventTest, QuitOutsideOfRun) {
std::unique_ptr<MessagePumpLibevent> pump(new MessagePumpLibevent);
- ASSERT_DCHECK_DEATH(pump->Quit(),
- "Check failed: in_run_. "
- "Quit was called outside of Run!");
+ ASSERT_DCHECK_DEATH(pump->Quit());
}
class BaseWatcher : public MessagePumpLibevent::Watcher {
« no previous file with comments | « base/message_loop/message_pump_io_ios_unittest.cc ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698