base/metrics/field_trial_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/metrics/field_trial_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/message_loop/message_pump_libevent_unittest.cc ('k') | base/metrics/histogram_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/metrics/field_trial.h"	5 #include "base/metrics/field_trial.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/build_time.h"	9 #include "base/build_time.h"

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 1110 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1121 EXPECT_TRUE(field_trial_list.TrialExists("zzz"));	1121 EXPECT_TRUE(field_trial_list.TrialExists("zzz"));

1122 }	1122 }

1123	1123

1124 TEST(FieldTrialDeathTest, OneTimeRandomizedTrialWithoutFieldTrialList) {	1124 TEST(FieldTrialDeathTest, OneTimeRandomizedTrialWithoutFieldTrialList) {

1125 // Trying to instantiate a one-time randomized field trial before the	1125 // Trying to instantiate a one-time randomized field trial before the

1126 // FieldTrialList is created should crash.	1126 // FieldTrialList is created should crash.

1127 EXPECT_DCHECK_DEATH(	1127 EXPECT_DCHECK_DEATH(

1128 FieldTrialList::FactoryGetFieldTrial(	1128 FieldTrialList::FactoryGetFieldTrial(

1129 "OneTimeRandomizedTrialWithoutFieldTrialList", 100, kDefaultGroupName,	1129 "OneTimeRandomizedTrialWithoutFieldTrialList", 100, kDefaultGroupName,

1130 base::FieldTrialList::kNoExpirationYear, 1, 1,	1130 base::FieldTrialList::kNoExpirationYear, 1, 1,

1131 base::FieldTrial::ONE_TIME_RANDOMIZED, NULL),	1131 base::FieldTrial::ONE_TIME_RANDOMIZED, NULL));

1132 "");

1133 }	1132 }

1134	1133

1135 } // namespace base	1134 } // namespace base

OLD	NEW