Non-strict cast in showCustomInputAccessoryView:

Non-strict cast in showCustomInputAccessoryView:

FormInputAccessoryViewController's -showCustomInputAccessoryView: intends to
handle the case when the view is a suggestion view and there are no
suggestions by not showing the view.

The code seems to have this pattern:
  try to cast the view into a suggestion view
  if (succeeded in the cast) {
    handle the 0-suggestion case
  }
Also, https://codereview.chromium.org/1310813002 which introduced this code has a
description indicating that the non-suggestion-view case should be handled
gracefully.

Yet, the code uses ObjCCastStrict instead of ObjCCast. The strict cast DCHECKs
that the casted object is indeed of the target type, whereas the non-strict
cast just returns nil if it is not.

Given the above, it seems more appropriate to use the non-strict cast, which
is done in this CL.

BUG=634245
R=jdonnelly@chromium.org

Committed: https://crrev.com/e26f52453211b4cba55ac5156f730691d1204b4b
Cr-Commit-Position: refs/heads/master@{#410394}

[vabr (Chromium), 2016-08-05 10:33:38]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 10:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-05 10:33:54]

Hi Justin,

PTAL.

Thank you!
Vaclav

[commit-bot: I haz the power, 2016-08-05 11:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:16:04]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-08-08 07:14:09]

Hi Justin,

A gentle ping for this one-liner change.

Cheers,
Vaclav

[Justin Donnelly, 2016-08-08 17:11:19]

lgtm

Sorry, I missed this on Friday. Thanks for the fix!

[vabr (Chromium), 2016-08-08 17:33:49]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-08-08 17:33:59]

On 2016/08/08 17:11:19, Justin Donnelly wrote:
> lgtm
> 
> Sorry, I missed this on Friday. Thanks for the fix!

Thank you! :)

[commit-bot: I haz the power, 2016-08-08 17:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 18:06:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-08 18:07:51]

Description was changed from

==========
Non-strict cast in showCustomInputAccessoryView:

FormInputAccessoryViewController's -showCustomInputAccessoryView: intends to
handle the case when the view is a suggestion view and there are no
suggestions by not showing the view.

The code seems to have this pattern:
  try to cast the view into a suggestion view
  if (succeeded in the cast) {
    handle the 0-suggestion case
  }
Also, https://codereview.chromium.org/1310813002 which introduced this code has
a
description indicating that the non-suggestion-view case should be handled
gracefully.

Yet, the code uses ObjCCastStrict instead of ObjCCast. The strict cast DCHECKs
that the casted object is indeed of the target type, whereas the non-strict
cast just returns nil if it is not.

Given the above, it seems more appropriate to use the non-strict cast, which
is done in this CL.

BUG=634245
R=jdonnelly@chromium.org
==========

to

==========
Non-strict cast in showCustomInputAccessoryView:

FormInputAccessoryViewController's -showCustomInputAccessoryView: intends to
handle the case when the view is a suggestion view and there are no
suggestions by not showing the view.

The code seems to have this pattern:
  try to cast the view into a suggestion view
  if (succeeded in the cast) {
    handle the 0-suggestion case
  }
Also, https://codereview.chromium.org/1310813002 which introduced this code has
a
description indicating that the non-suggestion-view case should be handled
gracefully.

Yet, the code uses ObjCCastStrict instead of ObjCCast. The strict cast DCHECKs
that the casted object is indeed of the target type, whereas the non-strict
cast just returns nil if it is not.

Given the above, it seems more appropriate to use the non-strict cast, which
is done in this CL.

BUG=634245
R=jdonnelly@chromium.org

Committed: https://crrev.com/e26f52453211b4cba55ac5156f730691d1204b4b
Cr-Commit-Position: refs/heads/master@{#410394}
==========

[commit-bot: I haz the power, 2016-08-08 18:07:53]

Patchset 1 (id:??) landed as
https://crrev.com/e26f52453211b4cba55ac5156f730691d1204b4b
Cr-Commit-Position: refs/heads/master@{#410394}