ios/chrome/browser/autofill/form_input_accessory_view_controller.mm - Issue 2213383003: Non-strict cast in showCustomInputAccessoryView:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Issue 2213383003: Non-strict cast in showCustomInputAccessoryView: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

diff --git a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm b/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

index 2ae1b68bb5bc8a920b09013e252a20e967b8e677..ab2b589494f195a860282c234ca8a72657c684bb 100644

--- a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

+++ b/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

@@ -336,7 +336,7 @@ bool ComputeFramesOfKeyboardParts(UIView* inputAccessoryView,

// If this is a form suggestion view and no suggestions have been triggered

// yet, don't show the custom view.

FormSuggestionView* formSuggestionView =

- base::mac::ObjCCastStrict<FormSuggestionView>(view);

+ base::mac::ObjCCast<FormSuggestionView>(view);

if (formSuggestionView) {

int numSuggestions = [[formSuggestionView suggestions] count];

if (!_suggestionsHaveBeenShown && numSuggestions == 0) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »