Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1310813002: Fix for iPads running iOS 9 to no longer crash on pw generation. (Closed)

Created:
5 years, 4 months ago by Justin Donnelly
Modified:
5 years, 4 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for iPads running iOS 9 to no longer crash on pw generation. A new code path for autofill/password-generation views was added in https://codereview.chromium.org/1305433003 to support iPads running iOS 9 which no longer have a keyboard accessory. However, that change assumed that the view was an autofill view and crashed in the password generation case. This CL fixes the assumption. BUG=518906 TBR=pkl Committed: https://crrev.com/e81fa04ccb056c285d14e93966bd663d15d1d848 Cr-Commit-Position: refs/heads/master@{#344902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
justincohen
lgtm
5 years, 4 months ago (2015-08-21 23:17:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310813002/1
5 years, 4 months ago (2015-08-21 23:21:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 23:27:46 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e81fa04ccb056c285d14e93966bd663d15d1d848 Cr-Commit-Position: refs/heads/master@{#344902}
5 years, 4 months ago (2015-08-21 23:28:27 UTC) #6
Justin Donnelly
Update the CL description for posterity. Hopefully it's more clear now.
5 years, 4 months ago (2015-08-21 23:31:33 UTC) #7
Eugene But (OOO till 7-30)
5 years, 4 months ago (2015-08-22 00:57:38 UTC) #9
Message was sent while issue was closed.
Justin asked me to take a look at this CL. lgtm. Description is now good, thanks

Powered by Google App Engine
This is Rietveld 408576698