Make net::HttpRequestHeaders::AddHeadersFromString split on NL

Make net::HttpRequestHeaders::AddHeadersFromString split on NL

Previously, AddHeaderFromString() only split on CRNL
terminators. However, some HTTP servers will treat an individual CR or NL
as a line terminator. This could lead to a difference of interpretation
between what Chrome intended to send and what the server thought it
received.

To avoid this, make AddHeadersFromString split on individual CR and NL
characters.

No code should be calling AddHeadersFromString with individual CR or NL
embedded, so this change should not break anything that was not broken
already.

BUG=634225
TEST=net_unittests

[Adam Rice, 2016-08-04 07:39:22]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 07:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 08:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 08:48:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Adam Rice, 2016-08-04 09:45:50]

ricea@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Adam Rice, 2016-08-22 07:28:26]

This problem was fixed in a different way by having  AddHeaderFromString filter
out bad headers, so this change
is no longer needed.

[Adam Rice, 2016-08-22 07:28:34]

Description was changed from

==========
Make net::HttpRequestHeaders::AddHeadersFromString split on NL

Previously, AddHeaderFromString() only split on CRNL
terminators. However, some HTTP servers will treat an individual CR or NL
as a line terminator. This could lead to a difference of interpretation
between what Chrome intended to send and what the server thought it
received.

To avoid this, make AddHeadersFromString split on individual CR and NL
characters.

No code should be calling AddHeadersFromString with individual CR or NL
embedded, so this change should not break anything that was not broken
already.

BUG=634225
TEST=net_unittests
==========

to

==========
Make net::HttpRequestHeaders::AddHeadersFromString split on NL

Previously, AddHeaderFromString() only split on CRNL
terminators. However, some HTTP servers will treat an individual CR or NL
as a line terminator. This could lead to a difference of interpretation
between what Chrome intended to send and what the server thought it
received.

To avoid this, make AddHeadersFromString split on individual CR and NL
characters.

No code should be calling AddHeadersFromString with individual CR or NL
embedded, so this change should not break anything that was not broken
already.

BUG=634225
TEST=net_unittests
==========