Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: net/http/http_request_headers_unittest.cc

Issue 2212883002: Make net::HttpRequestHeaders::AddHeadersFromString split on NL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_request_headers.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_request_headers.h" 5 #include "net/http/http_request_headers.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 headers.AddHeaderFromString("Foo:"); 135 headers.AddHeaderFromString("Foo:");
136 EXPECT_EQ("Foo:\r\n\r\n", headers.ToString()); 136 EXPECT_EQ("Foo:\r\n\r\n", headers.ToString());
137 } 137 }
138 138
139 TEST(HttpRequestHeaders, AddHeaderFromStringWithWhitespaceValue) { 139 TEST(HttpRequestHeaders, AddHeaderFromStringWithWhitespaceValue) {
140 HttpRequestHeaders headers; 140 HttpRequestHeaders headers;
141 headers.AddHeaderFromString("Foo: "); 141 headers.AddHeaderFromString("Foo: ");
142 EXPECT_EQ("Foo:\r\n\r\n", headers.ToString()); 142 EXPECT_EQ("Foo:\r\n\r\n", headers.ToString());
143 } 143 }
144 144
145 TEST(HttpRequestHeaders, AddHeadersFromStringEmbeddedNewline) {
146 HttpRequestHeaders headers;
147 headers.AddHeadersFromString(
148 "Cache-Control: max-age=0\r\n"
149 "X-Powered-By: sugar\nOrigin: http://www.google.com");
150 EXPECT_EQ(
151 "Cache-Control: max-age=0\r\n"
152 "X-Powered-By: sugar\r\n"
153 "Origin: http://www.google.com\r\n"
154 "\r\n",
155 headers.ToString());
156 }
157
145 TEST(HttpRequestHeaders, MergeFrom) { 158 TEST(HttpRequestHeaders, MergeFrom) {
146 HttpRequestHeaders headers; 159 HttpRequestHeaders headers;
147 headers.SetHeader("A", "A"); 160 headers.SetHeader("A", "A");
148 headers.SetHeader("B", "B"); 161 headers.SetHeader("B", "B");
149 162
150 HttpRequestHeaders headers2; 163 HttpRequestHeaders headers2;
151 headers2.SetHeader("B", "b"); 164 headers2.SetHeader("B", "b");
152 headers2.SetHeader("C", "c"); 165 headers2.SetHeader("C", "c");
153 headers.MergeFrom(headers2); 166 headers.MergeFrom(headers2);
154 EXPECT_EQ("A: A\r\nB: b\r\nC: c\r\n\r\n", headers.ToString()); 167 EXPECT_EQ("A: A\r\nB: b\r\nC: c\r\n\r\n", headers.ToString());
(...skipping 25 matching lines...) Expand all
180 ASSERT_TRUE(HttpRequestHeaders::FromNetLogParam(event_param.get(), 193 ASSERT_TRUE(HttpRequestHeaders::FromNetLogParam(event_param.get(),
181 &headers2, 194 &headers2,
182 &request_line2)); 195 &request_line2));
183 EXPECT_EQ(request_line, request_line2); 196 EXPECT_EQ(request_line, request_line2);
184 EXPECT_EQ("B: b\r\nA: a\r\n\r\n", headers2.ToString()); 197 EXPECT_EQ("B: b\r\nA: a\r\n\r\n", headers2.ToString());
185 } 198 }
186 199
187 } // namespace 200 } // namespace
188 201
189 } // namespace net 202 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_request_headers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698