Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: net/http/http_request_headers_unittest.cc

Issue 2212883002: Make net::HttpRequestHeaders::AddHeadersFromString split on NL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_request_headers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_request_headers_unittest.cc
diff --git a/net/http/http_request_headers_unittest.cc b/net/http/http_request_headers_unittest.cc
index 6a09e4631e75b620838dc273e65f8cd4bbc5a6f5..70fa828ca4f33e24024be746b97cd0fb4bd183c1 100644
--- a/net/http/http_request_headers_unittest.cc
+++ b/net/http/http_request_headers_unittest.cc
@@ -142,6 +142,19 @@ TEST(HttpRequestHeaders, AddHeaderFromStringWithWhitespaceValue) {
EXPECT_EQ("Foo:\r\n\r\n", headers.ToString());
}
+TEST(HttpRequestHeaders, AddHeadersFromStringEmbeddedNewline) {
+ HttpRequestHeaders headers;
+ headers.AddHeadersFromString(
+ "Cache-Control: max-age=0\r\n"
+ "X-Powered-By: sugar\nOrigin: http://www.google.com");
+ EXPECT_EQ(
+ "Cache-Control: max-age=0\r\n"
+ "X-Powered-By: sugar\r\n"
+ "Origin: http://www.google.com\r\n"
+ "\r\n",
+ headers.ToString());
+}
+
TEST(HttpRequestHeaders, MergeFrom) {
HttpRequestHeaders headers;
headers.SetHeader("A", "A");
« no previous file with comments | « net/http/http_request_headers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698