Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2212713002:
MD Settings: add tests for <controlled-radio-button> (Closed)
|
Created:
4 years, 4 months ago by Dan Beam Modified:
4 years, 4 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@controlled-radio Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: add tests for <controlled-radio-button>
R=stevenjb@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://chromium.googlesource.com/chromium/src/+/2886ed1b1dd33d1d442ae8111cb05136fbd51ef9
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : merge #
Dependent Patchsets: Messages
Total messages: 27 (18 generated)
Description was changed from ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 ========== to ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2212713002/#ps20001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2212713002/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2886ed1b1dd33d1d442ae8111cb05136fbd51ef9 Cr-Commit-Position: refs/heads/master@{#409989} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2886ed1b1dd33d1d442ae8111cb05136fbd51ef9 Cr-Commit-Position: refs/heads/master@{#409989}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2886ed1b1dd33d1d442ae8111cb05136fbd51ef9 Cr-Commit-Position: refs/heads/master@{#409989} ========== to ========== MD Settings: add tests for <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://chromium.googlesource.com/chromium/src/+/2886ed1b1dd33d1d442ae8111cb0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 2886ed1b1dd33d1d442ae8111cb05136fbd51ef9 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
