Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/resources/settings/controls/controlled_radio_button.js

Issue 2212713002: MD Settings: add tests for <controlled-radio-button> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@controlled-radio
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/controlled_radio_button_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/controlled_radio_button.js
diff --git a/chrome/browser/resources/settings/controls/controlled_radio_button.js b/chrome/browser/resources/settings/controls/controlled_radio_button.js
index dd758323af607f0078329276aade26359f965165..33dc95979e7ea356b9a40952cba52bb0b33ade97 100644
--- a/chrome/browser/resources/settings/controls/controlled_radio_button.js
+++ b/chrome/browser/resources/settings/controls/controlled_radio_button.js
@@ -16,19 +16,17 @@ Polymer({
/** @private */
controlled_: {
type: Boolean,
- computed: 'computeControlled_(pref)',
+ computed: 'computeControlled_(pref.*)',
reflectToAttribute: true,
},
},
/**
- * @param {chrome.settingsPrivate.PrefObject} pref
* @return {boolean} Whether the button is disabled.
* @private
*/
- computeControlled_: function(pref) {
- var pref = /** @type {!chrome.settingsPrivate.PrefObject} */(this.pref);
- return this.isPrefPolicyControlled(pref);
+ computeControlled_: function() {
+ return this.isPrefPolicyControlled(assert(this.pref));
},
/**
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/controlled_radio_button_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698