Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2216053002: MD Settings: closure compile <controlled-radio-button> (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@controlled-radio-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: closure compile <controlled-radio-button> R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bef36761c97f07ef87860cbd2c2cedecc3b29467 Cr-Commit-Position: refs/heads/master@{#409990}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/resources/settings/controls/compiled_resources2.gyp View 1 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Dan Beam
4 years, 4 months ago (2016-08-04 22:37:02 UTC) #2
stevenjb
lgtm
4 years, 4 months ago (2016-08-04 23:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216053002/20001
4 years, 4 months ago (2016-08-05 04:31:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 04:37:12 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 04:39:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bef36761c97f07ef87860cbd2c2cedecc3b29467
Cr-Commit-Position: refs/heads/master@{#409990}

Powered by Google App Engine
This is Rietveld 408576698