Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2212493002: Convert SkAutoTUnref<SkData> to sk_sp<SkData>. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert SkAutoTUnref<SkData> to sk_sp<SkData>. With the move from SkData::NewXXX to SkData::MakeXXX most SkAutoTUnref<SkData> were changed to sk_sp<SkData>. However, there are still a few SkAutoTUnref<SkData> around, so clean them up. Committed: https://skia.googlesource.com/skia/+/ffae30db4ade45b469ac3432ec373b6f6daee6e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -42 lines) Patch
M bench/AndroidCodecBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/AndroidCodecBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/BitmapRegionDecoderBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapRegionDecoderBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M bench/CodecBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/CodecBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/EncoderBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fuzz/FilterFuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fuzz/Fuzz.h View 1 chunk +1 line, -1 line 0 comments Download
M gm/image.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkCodecImageGenerator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageCacherator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkWriteBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageGeneratorCG.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageGeneratorWIC.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/CodecTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PDFJpegEmbedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PDFMetadataAttributeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/StreamTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/ktx/ktx.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/UrlDataManager.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/BreakHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/visualize_color_gamut.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
bungeman-skia
4 years, 4 months ago (2016-08-03 18:13:20 UTC) #7
reed1
lgtm
4 years, 4 months ago (2016-08-03 20:17:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212493002/1
4 years, 4 months ago (2016-08-03 20:31:33 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:32:35 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffae30db4ade45b469ac3432ec373b6f6daee6e7

Powered by Google App Engine
This is Rietveld 408576698