Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2212393002: Report the size of |ScriptResource::m_script| as decoded size (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
hajimehoshi, yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report the size of |ScriptResource::m_script| as decoded size Previously, |m_script| was reported as encoded data, while it is not |m_data|. This CL reports |m_script| as decoded data and call setEncodedSizeMemoryUsage(0) instead, to prevent |m_script| from being reported both as encoded and decoded data to memory-infra. BUG=643135 Committed: https://crrev.com/e95fdfd5cb10bc3f0e99916374b55d917d004f96 Cr-Commit-Position: refs/heads/master@{#430483}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
hiroshige
PTAL, yhirano@ as core/fetch OWNER, hajimehoshi@ from memory-reporting-related viewpoints.
4 years, 1 month ago (2016-11-07 09:04:46 UTC) #8
hiroshige
On 2016/11/07 08:26:18, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 1 month ago (2016-11-07 09:08:14 UTC) #11
hajimehoshi
lgtm
4 years, 1 month ago (2016-11-07 11:05:57 UTC) #15
yhirano
lgtm
4 years, 1 month ago (2016-11-08 02:16:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212393002/80001
4 years, 1 month ago (2016-11-08 02:25:26 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 02:33:47 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:27:20 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e95fdfd5cb10bc3f0e99916374b55d917d004f96
Cr-Commit-Position: refs/heads/master@{#430483}

Powered by Google App Engine
This is Rietveld 408576698