Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

Issue 2212393002: Report the size of |ScriptResource::m_script| as decoded size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 memoryDump->addSuballocation( 82 memoryDump->addSuballocation(
83 dump->guid(), String(WTF::Partitions::kAllocatedObjectPoolName)); 83 dump->guid(), String(WTF::Partitions::kAllocatedObjectPoolName));
84 } 84 }
85 85
86 const String& ScriptResource::script() { 86 const String& ScriptResource::script() {
87 DCHECK(isLoaded()); 87 DCHECK(isLoaded());
88 88
89 if (m_script.isNull() && data()) { 89 if (m_script.isNull() && data()) {
90 String script = decodedText(); 90 String script = decodedText();
91 clearData(); 91 clearData();
92 // We lie a bit here and claim that script counts as encoded data (even 92 setEncodedSizeMemoryUsage(0);
93 // though it's really decoded data). That's because the MemoryCache thinks 93 setDecodedSize(script.charactersSizeInBytes());
94 // that it can clear out decoded data by calling destroyDecodedData(), but
95 // we can't destroy script in destroyDecodedData because that's our only
96 // copy of the data!
97 setEncodedSize(script.charactersSizeInBytes());
98 m_script = AtomicString(script); 94 m_script = AtomicString(script);
99 } 95 }
100 96
101 return m_script; 97 return m_script;
102 } 98 }
103 99
104 void ScriptResource::destroyDecodedDataForFailedRevalidation() { 100 void ScriptResource::destroyDecodedDataForFailedRevalidation() {
105 m_script = AtomicString(); 101 m_script = AtomicString();
106 } 102 }
107 103
108 bool ScriptResource::mimeTypeAllowedByNosniff() const { 104 bool ScriptResource::mimeTypeAllowedByNosniff() const {
109 return parseContentTypeOptionsHeader(response().httpHeaderField( 105 return parseContentTypeOptionsHeader(response().httpHeaderField(
110 HTTPNames::X_Content_Type_Options)) != ContentTypeOptionsNosniff || 106 HTTPNames::X_Content_Type_Options)) != ContentTypeOptionsNosniff ||
111 MIMETypeRegistry::isSupportedJavaScriptMIMEType(httpContentType()); 107 MIMETypeRegistry::isSupportedJavaScriptMIMEType(httpContentType());
112 } 108 }
113 109
114 } // namespace blink 110 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698