Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135
Committed: https://crrev.com/71b354672add64227227bc3dec0e5462f1e0dda4
Cr-Commit-Position: refs/heads/master@{#430521}

[hiroshige, 2016-11-07 07:26:53]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 07:27:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 08:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 08:11:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-11-07 09:05:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 09:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-07 09:10:47]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 09:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-07 09:15:44]

Description was changed from

==========
Report CSSStyleSheetResource::m_decodedSheetText size as decoded size

BUG=
==========

to

==========
Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135
==========

[hiroshige, 2016-11-07 09:17:17]

hiroshige@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, kouhei@chromium.org, yhirano@chromium.org

[hiroshige, 2016-11-07 09:17:18]

PTAL,
yhirano@ as core/fetch OWNER,
hajimehoshi@ from memory-reporting-related viewpoints,
kouhei@ as this is related to clearing |m_data| and having the decoded data in
m_decodedSheetText after load finished.

setEncodedSizeMemoryUsage() call will be moved into clearData() in a follow-up
CL.

[kouhei (in TOK), 2016-11-07 09:29:39]

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:79:
m_parsedStyleSheetCache->setReferencedFromResource(this);
Can we add a comment here:
// update decoded size to take parsed stylesheet cache into account.

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:168:
updateDecodedSize();
Can we skip it here? destroyDecodedDataIfPossible will zero-out decoded size
anyway

[hiroshige, 2016-11-07 09:35:56]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2016-11-07 09:36:07]

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:79:
m_parsedStyleSheetCache->setReferencedFromResource(this);
On 2016/11/07 09:29:39, kouhei wrote:
> Can we add a comment here:
> // update decoded size to take parsed stylesheet cache into account.

Done.

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:168:
updateDecodedSize();
On 2016/11/07 09:29:39, kouhei wrote:
> Can we skip it here? destroyDecodedDataIfPossible will zero-out decoded size
> anyway

I thought destroyDecodedDataIfPossible() doesn't call setParsedStyleSheetCache
(and setDecodedSize()) if m_parsedStyleSheetCache is nullptr, so I placed this
call here.
(I'm not sure whether this can happen though)

[hiroshige, 2016-11-07 09:36:20]

The CQ bit was unchecked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-07 09:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-07 09:57:42]

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2477293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:168:
updateDecodedSize();
On 2016/11/07 09:36:07, hiroshige wrote:
> On 2016/11/07 09:29:39, kouhei wrote:
> > Can we skip it here? destroyDecodedDataIfPossible will zero-out decoded size
> > anyway
> 
> I thought destroyDecodedDataIfPossible() doesn't call setParsedStyleSheetCache
> (and setDecodedSize()) if m_parsedStyleSheetCache is nullptr, so I placed this
> call here.
> (I'm not sure whether this can happen though)

Makes sense. lgtm

[hajimehoshi, 2016-11-07 11:11:34]

https://codereview.chromium.org/2477293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2477293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:142:
updateDecodedSize();
I'd make setDecodedSheetText and call updateDecodedSize there

[hiroshige, 2016-11-07 11:40:35]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:40:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-07 11:41:20]

https://codereview.chromium.org/2477293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2477293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:142:
updateDecodedSize();
On 2016/11/07 11:11:34, hajimehoshi wrote:
> I'd make setDecodedSheetText and call updateDecodedSize there

Done.

[commit-bot: I haz the power, 2016-11-07 12:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 12:59:09]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-08 02:35:09]

lgtm

[hajimehoshi, 2016-11-08 04:30:49]

lgtm

[hiroshige, 2016-11-08 04:39:43]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-08 04:39:43]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2477293002/#ps60001
(title: "setDecodedSheetText()")

[commit-bot: I haz the power, 2016-11-08 04:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 05:03:17]

Description was changed from

==========
Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135
==========

to

==========
Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135
==========

[commit-bot: I haz the power, 2016-11-08 05:03:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-08 05:05:12]

Description was changed from

==========
Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135
==========

to

==========
Report the size of |CSSStyleSheetResource::m_decodedSheetText| as decoded size

Previously, |m_decodedSheetText| was reported as encoded data, while it is
not |m_data|.
This CL reports |m_decodedSheetText| as decoded data and call
setEncodedSizeMemoryUsage(0) instead, to prevent |m_decodedSheetText| from being
reported both as encoded and decoded data to memory-infra.

This CL also makes setParsedStyleSheetCache() to always update the decoded
size, while the decoded size was not updated in some call sites of
setParsedStyleSheetCache().

BUG=643135

Committed: https://crrev.com/71b354672add64227227bc3dec0e5462f1e0dda4
Cr-Commit-Position: refs/heads/master@{#430521}
==========

[commit-bot: I haz the power, 2016-11-08 05:05:14]

Patchset 4 (id:??) landed as
https://crrev.com/71b354672add64227227bc3dec0e5462f1e0dda4
Cr-Commit-Position: refs/heads/master@{#430521}