extensions/browser/api/declarative/rules_registry_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_instance_impl_unittest.cc ('K') | « device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc ('k') | extensions/shell/test/shell_test.cc » ('j') | extensions/shell/test/shell_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/rules_registry_unittest.cc

diff --git a/extensions/browser/api/declarative/rules_registry_unittest.cc b/extensions/browser/api/declarative/rules_registry_unittest.cc

index edf91514f5d722bf67de9b69ac3d5fc5b3a40bd2..4598a07145a2fe12101e0d17f359aba236ea53d2 100644

--- a/extensions/browser/api/declarative/rules_registry_unittest.cc

+++ b/extensions/browser/api/declarative/rules_registry_unittest.cc

@@ -8,6 +8,7 @@

#include <utility>

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/values.h"

#include "content/public/test/test_browser_thread.h"

#include "extensions/browser/api/declarative/rules_registry_service.h"

@@ -143,7 +144,7 @@ TEST(RulesRegistryTest, FillOptionalIdentifiers) {

// Make sure that deletion traits of registry are executed.

registry = NULL;

- message_loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

TEST(RulesRegistryTest, FillOptionalPriority) {

@@ -179,7 +180,7 @@ TEST(RulesRegistryTest, FillOptionalPriority) {

// Make sure that deletion traits of registry are executed.

registry = NULL;

- message_loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

// Test verifies 2 rules defined in the manifest appear in the registry.