content/renderer/media/media_stream_video_renderer_sink_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_renderer_sink_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_instance_impl_unittest.cc ('K') | « content/renderer/media/media_stream_video_capturer_source_unittest.cc ('k') | dbus/end_to_end_async_unittest.cc » ('j') | extensions/shell/test/shell_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_renderer_sink_unittest.cc

diff --git a/content/renderer/media/media_stream_video_renderer_sink_unittest.cc b/content/renderer/media/media_stream_video_renderer_sink_unittest.cc

index 258b7a7bb3913a386d586ea284d83574768445ca..79c91c3c69fe53a3facbe15213c723d048457adc 100644

--- a/content/renderer/media/media_stream_video_renderer_sink_unittest.cc

+++ b/content/renderer/media/media_stream_video_renderer_sink_unittest.cc

@@ -149,12 +149,12 @@ TEST_F(MediaStreamVideoRendererSinkAsyncAddFrameReadyTest,

const scoped_refptr<media::VideoFrame> video_frame =

media::VideoFrame::CreateBlackFrame(gfx::Size(160, 80));

OnVideoFrame(video_frame);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ASSERT_EQ(1u, frame_ready_cbs_.size());

EXPECT_CALL(*this, RepaintCallback(video_frame)).Times(1);

frame_ready_cbs_[0].Run();

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

media_stream_video_renderer_sink_->Stop();

}

@@ -190,7 +190,7 @@ TEST_F(MediaStreamVideoRendererSinkTransparencyTest,

media::VideoFrame::CreateFrame(media::PIXEL_FORMAT_YV12A, kSize,

gfx::Rect(kSize), kSize, kTimestamp);

OnVideoFrame(video_frame);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

media_stream_video_renderer_sink_->Stop();

}