[MD settings] remove overscroll in subpages

[MD settings] remove overscroll in subpages

This CL removes the overscroll while viewing a subpage.

BUG=634582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[dschuyler, 2016-08-05 16:09:21]

Description was changed from

==========
[MD settings] hide overscroll in subpages

This CL removes the overscroll while viewing a subpage.

BUG=634582
==========

to

==========
[MD settings] hide overscroll in subpages

This CL removes the overscroll while viewing a subpage.

BUG=634582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-05 16:09:24]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 16:09:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-05 16:13:10]

Description was changed from

==========
[MD settings] hide overscroll in subpages

This CL removes the overscroll while viewing a subpage.

BUG=634582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove overscroll in subpages

This CL removes the overscroll while viewing a subpage.

BUG=634582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-05 16:13:10]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:17:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-08-05 17:33:19]

does this work well when navigating to a subpage with overscroll and then going
back?

[dschuyler, 2016-08-05 17:40:23]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-05 17:44:33]

On 2016/08/05 17:33:19, Dan Beam wrote:
> does this work well when navigating to a subpage with overscroll and then
going
> back?

Thanks for asking. It's better as a 'hidden' rather than a 'template' (since a
template
can have those timing issues about whether the template is currently expanded).
(And template on one div was kinda overkill).
Patch #2 changes it to a hidden$="..." which looks reliable.

[commit-bot: I haz the power, 2016-08-05 18:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:41:00]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-06 00:09:14]

i don't really think this is what we want, because the overscroll is removed
before the page has had enough time to animate to full height.

[michaelpg, 2016-08-08 18:36:41]

On 2016/08/06 00:09:14, Dan Beam wrote:
> i don't really think this is what we want, because the overscroll is removed
> before the page has had enough time to animate to full height.

yeah. In my (closed to split up into smaller CLs) CL here you can see how I
dealt with this by adding events to disable/re-enable overscroll changes:
https://codereview.chromium.org/2106013002/diff/320001/chrome/browser/resourc...

Not sure if that's the right solution, but yeah -- in general overscroll changes
shouldn't be allowed to make the page *jump*.