Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2224303003: MD User Manager: change last of i18n-* to $i18n{} (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
tommycli, Moe
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: change last of i18n-* to $i18n{} R=mahmadi@chromium.org BUG=498405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/b697aba165a4dc17d453615e337121f86882744c Cr-Commit-Position: refs/heads/master@{#410750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/resources/md_user_manager/control_bar.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager.html View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
Dan Beam
4 years, 4 months ago (2016-08-09 16:23:23 UTC) #2
Moe
On 2016/08/09 16:23:23, Dan Beam wrote: lgtm Thank you. you probably still need a committer's ...
4 years, 4 months ago (2016-08-09 17:19:46 UTC) #5
Dan Beam
+tommycli@
4 years, 4 months ago (2016-08-09 17:20:28 UTC) #7
tommycli
lgtm thanks
4 years, 4 months ago (2016-08-09 17:28:13 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2211403003 Patch 20001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-09 17:31:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224303003/1
4 years, 4 months ago (2016-08-09 17:33:56 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 18:24:46 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:27:59 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b697aba165a4dc17d453615e337121f86882744c
Cr-Commit-Position: refs/heads/master@{#410750}

Powered by Google App Engine
This is Rietveld 408576698