Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2224923004: MD Extensions: convert last i18n-* attributes to $i18n{} (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Extensions: convert last i18n-* attributes to $i18n{} R=rdevlin.cronin@chromium.org BUG=498405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/4cfe17991bfd4760efd24e18cc622d32064c8f84 Cr-Commit-Position: refs/heads/master@{#410770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/resources/md_extensions/extensions.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_extensions/manager.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_extensions/sidebar.html View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Dan Beam
4 years, 4 months ago (2016-08-09 16:10:54 UTC) #2
Devlin
lgtm
4 years, 4 months ago (2016-08-09 19:01:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224923004/1
4 years, 4 months ago (2016-08-09 19:03:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 19:46:12 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:48:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cfe17991bfd4760efd24e18cc622d32064c8f84
Cr-Commit-Position: refs/heads/master@{#410770}

Powered by Google App Engine
This is Rietveld 408576698