Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with painted...

Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect (patchset #9 id:160001 of https://codereview.chromium.org/2203933002/ )

Reason for revert:
With the CL, LayoutBox::getPaintInvalidationReason() sometimes returns PaintInvalidationIncremental when paintedOutputOfObjectHasNoEffect() is true.

Original issue's description:
> Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect
> 
> We don't need to check if the layout is laid out because of children,
> but just check if it will paint anything and if its painting is
> affected by geometry change.
> 
> Removed neededLayoutBecauseOfChildren logic and replaced
> skipInvalidationWhenLaiedOutChildren() with
> paintedOutputOfObjectHasNoEffect().
> 
> Also cleaned up selection paint invalidation.
> 
> BUG=451090
> 
> Committed: https://crrev.com/bdd41f4e784486fd7522793283cb5c376a057f0a
> Cr-Commit-Position: refs/heads/master@{#409965}

TBR=chrishtr@chromium.org,trchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451090, 643807

[Xianzhu, 2016-08-05 17:06:45]

Created Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren()
with paintedOutputOfObjectHasNoEffect

[Xianzhu, 2016-08-05 17:07:39]

Description was changed from

==========
Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with
paintedOutputOfObjectHasNoEffect (patchset #9 id:160001 of
https://codereview.chromium.org/2203933002/ )

Reason for revert:
With the CL, LayoutBox::getPaintInvalidationReason() sometimes returns
PaintInvalidationIncremental when paintedOutputOfObjectHasNoEffect() is true.

Original issue's description:
> Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with
paintedOutputOfObjectHasNoEffect
> 
> We don't need to check if the layout is laid out because of children,
> but just check if it will paint anything and if its painting is
> affected by geometry change.
> 
> Removed neededLayoutBecauseOfChildren logic and replaced
> skipInvalidationWhenLaiedOutChildren() with
> paintedOutputOfObjectHasNoEffect().
> 
> Also cleaned up selection paint invalidation.
> 
> BUG=451090
> 
> Committed: https://crrev.com/bdd41f4e784486fd7522793283cb5c376a057f0a
> Cr-Commit-Position: refs/heads/master@{#409965}

TBR=chrishtr@chromium.org,trchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451090
==========

to

==========
Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with
paintedOutputOfObjectHasNoEffect (patchset #9 id:160001 of
https://codereview.chromium.org/2203933002/ )

Reason for revert:
With the CL, LayoutBox::getPaintInvalidationReason() sometimes returns
PaintInvalidationIncremental when paintedOutputOfObjectHasNoEffect() is true.

Original issue's description:
> Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with
paintedOutputOfObjectHasNoEffect
> 
> We don't need to check if the layout is laid out because of children,
> but just check if it will paint anything and if its painting is
> affected by geometry change.
> 
> Removed neededLayoutBecauseOfChildren logic and replaced
> skipInvalidationWhenLaiedOutChildren() with
> paintedOutputOfObjectHasNoEffect().
> 
> Also cleaned up selection paint invalidation.
> 
> BUG=451090
> 
> Committed: https://crrev.com/bdd41f4e784486fd7522793283cb5c376a057f0a
> Cr-Commit-Position: refs/heads/master@{#409965}

TBR=chrishtr@chromium.org,trchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451090,643807
==========

[Xianzhu, 2016-08-05 17:14:20]

On 2016/08/05 17:06:45, Xianzhu wrote:
> Created Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren()
> with paintedOutputOfObjectHasNoEffect

Because many tests have been rebaselined, reverting this CL may need more work
than fixing the bug. Closing this CL and will fix the bug instead.