Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2211283003: Revert of Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with painted... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 7a739571095415dfd677e44b05786def16d6c3fe..89b23b078658cced2b4731d5f485539a9a6f9bb3 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2032,28 +2032,6 @@
bool LayoutBox::needsForcedBreakBefore(EBreak previousBreakAfterValue) const
{
return isForcedFragmentainerBreakValue(classABreakPointValue(previousBreakAfterValue));
-}
-
-bool LayoutBox::paintedOutputOfObjectHasNoEffect() const
-{
- // In case scrollbars got repositioned (which will typically happen if the box got
- // resized), we cannot skip invalidation.
- if (hasNonCompositedScrollbars())
- return false;
-
- // Cannot skip paint invalidation if the box has real things to paint.
- if (getSelectionState() != SelectionNone || hasBoxDecorationBackground() || styleRef().hasVisualOverflowingEffect())
- return false;
-
- // If the box has clip, we need issue a paint invalidation to cover the changed part of
- // children because of change of clip when the box got resized. In theory the children
- // should invalidate themselves when ancestor clip changes, but for now this is missing
- // and ensuring it may hurt performance.
- // TODO(wangxianzhu): Paint invalidation for clip change will be different in spv2.
- if (hasClipRelatedProperty() || hasControlClip())
- return false;
-
- return true;
}
LayoutRect LayoutBox::localOverflowRectForPaintInvalidation() const
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698