Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2211263003: WebViewPlugin: Make WebView resize take place synchronously. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

WebViewPlugin: Make WebView resize take place synchronously. Previously, we committed https://codereview.chromium.org/2164753003 to fix a crash. That patch made geometry-triggered updates asynchronous. However, this leads to visual artifacts. This CL makes some of those operations synchronous again, but should leave the crashy parts still async. BUG=631428 Review-Url: https://codereview.chromium.org/2205693007 Cr-Commit-Position: refs/heads/master@{#409709} (cherry picked from commit 7d02278211e46de5b07ac2cdaf26eecc3bf224bb) Committed: https://chromium.googlesource.com/chromium/src/+/501e16d2ff332db2b65240935eec936dab69a02b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M components/plugins/renderer/webview_plugin.cc View 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tommycli
4 years, 4 months ago (2016-08-05 17:14:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
501e16d2ff332db2b65240935eec936dab69a02b.

Powered by Google App Engine
This is Rietveld 408576698