WebViewPlugin: Post geometry-update actions to a task to run async.

WebViewPlugin: Post geometry-update actions to a task to run async.

WebViewPlugin resizes itself and actually may load a new plugin in
response to a geometry update.

Geometry updates are triggered during layout, and Blink assumes these
things can't happen during layout.

Therefore, post these actions to a task to run asynchronously. This is
the same approach that PepperPluginInstanceImpl takes.

BUG=628629
Committed: https://crrev.com/d16e91647e4238b13301fdfc3dce960427f4d18e
Cr-Commit-Position: refs/heads/master@{#406908}

[tommycli, 2016-07-20 17:17:11]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-07-20 17:45:13]

tommycli@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[tommycli, 2016-07-20 17:45:13]

esprehn OR dcheng: PTAL - this fixes the plugin updates during Blink layout
crash. (I think)

Thanks,

Tommy

[commit-bot: I haz the power, 2016-07-20 18:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:07:01]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-07-21 01:51:46]

https://codereview.chromium.org/2164753003/diff/40001/components/plugins/rend...
File components/plugins/renderer/webview_plugin.cc (right):

https://codereview.chromium.org/2164753003/diff/40001/components/plugins/rend...
components/plugins/renderer/webview_plugin.cc:357: web_view_->resize(newSize);
I think you can just say rect_.size() here: it's the same amount of work, but
less typing since the code won't have to explicitly instantiate WebSize.

[dcheng, 2016-07-21 01:52:40]

oops, meant to lgtm as well

[tommycli, 2016-07-21 17:42:23]

dcheng: thanks!

https://codereview.chromium.org/2164753003/diff/40001/components/plugins/rend...
File components/plugins/renderer/webview_plugin.cc (right):

https://codereview.chromium.org/2164753003/diff/40001/components/plugins/rend...
components/plugins/renderer/webview_plugin.cc:357: web_view_->resize(newSize);
On 2016/07/21 01:51:46, dcheng wrote:
> I think you can just say rect_.size() here: it's the same amount of work, but
> less typing since the code won't have to explicitly instantiate WebSize.

Done.

[tommycli, 2016-07-21 17:42:26]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-07-21 17:42:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2164753003/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-07-21 17:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-21 17:54:21]

lgtm thanks!

[commit-bot: I haz the power, 2016-07-21 18:23:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 18:25:22]

Description was changed from

==========
WebViewPlugin: Post geometry-update actions to a task to run async.

WebViewPlugin resizes itself and actually may load a new plugin in
response to a geometry update.

Geometry updates are triggered during layout, and Blink assumes these
things can't happen during layout.

Therefore, post these actions to a task to run asynchronously. This is
the same approach that PepperPluginInstanceImpl takes.

BUG=628629
==========

to

==========
WebViewPlugin: Post geometry-update actions to a task to run async.

WebViewPlugin resizes itself and actually may load a new plugin in
response to a geometry update.

Geometry updates are triggered during layout, and Blink assumes these
things can't happen during layout.

Therefore, post these actions to a task to run asynchronously. This is
the same approach that PepperPluginInstanceImpl takes.

BUG=628629

Committed: https://crrev.com/d16e91647e4238b13301fdfc3dce960427f4d18e
Cr-Commit-Position: refs/heads/master@{#406908}
==========

[commit-bot: I haz the power, 2016-07-21 18:25:22]

Patchset 4 (id:??) landed as
https://crrev.com/d16e91647e4238b13301fdfc3dce960427f4d18e
Cr-Commit-Position: refs/heads/master@{#406908}