WebViewPlugin: Make WebView resize take place synchronously.

WebViewPlugin: Make WebView resize take place synchronously.

Previously, we committed https://codereview.chromium.org/2164753003 to
fix a crash. That patch made geometry-triggered updates asynchronous.

However, this leads to visual artifacts. This CL makes some of those
operations synchronous again, but should leave the crashy parts still
async.

BUG=631428
Committed: https://crrev.com/7d02278211e46de5b07ac2cdaf26eecc3bf224bb
Cr-Commit-Position: refs/heads/master@{#409709}

[tommycli, 2016-08-03 16:58:51]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 16:59:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-03 17:00:16]

tommycli@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[tommycli, 2016-08-03 17:00:17]

dcheng / esprehn: PTAL. Fixes the visual artifacts. Maintains the crash fix too
(probably).

Not sure why there were visual artifacts in the first place.

[commit-bot: I haz the power, 2016-08-03 17:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 17:49:18]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-08-04 01:48:51]

lgtm

https://codereview.chromium.org/2205693007/diff/1/components/plugins/renderer...
File components/plugins/renderer/webview_plugin.cc (right):

https://codereview.chromium.org/2205693007/diff/1/components/plugins/renderer...
components/plugins/renderer/webview_plugin.cc:361:
delegate_->OnUnobscuredRectUpdate(gfx::Rect(unobscured_rect));
Nit: perhaps comment that this is what can actually instantiate the plugin.

[tommycli, 2016-08-04 02:10:12]

dcheng: thanks!!

https://codereview.chromium.org/2205693007/diff/1/components/plugins/renderer...
File components/plugins/renderer/webview_plugin.cc (right):

https://codereview.chromium.org/2205693007/diff/1/components/plugins/renderer...
components/plugins/renderer/webview_plugin.cc:361:
delegate_->OnUnobscuredRectUpdate(gfx::Rect(unobscured_rect));
On 2016/08/04 01:48:51, dcheng (OOO Aug 1 - Aug 11) wrote:
> Nit: perhaps comment that this is what can actually instantiate the plugin.

Done.

[tommycli, 2016-08-04 02:10:25]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-04 02:10:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2205693007/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-08-04 02:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-04 02:23:52]

lgtm

[commit-bot: I haz the power, 2016-08-04 02:43:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 02:45:12]

Description was changed from

==========
WebViewPlugin: Make WebView resize take place synchronously.

Previously, we committed https://codereview.chromium.org/2164753003 to
fix a crash. That patch made geometry-triggered updates asynchronous.

However, this leads to visual artifacts. This CL makes some of those
operations synchronous again, but should leave the crashy parts still
async.

BUG=631428
==========

to

==========
WebViewPlugin: Make WebView resize take place synchronously.

Previously, we committed https://codereview.chromium.org/2164753003 to
fix a crash. That patch made geometry-triggered updates asynchronous.

However, this leads to visual artifacts. This CL makes some of those
operations synchronous again, but should leave the crashy parts still
async.

BUG=631428

Committed: https://crrev.com/7d02278211e46de5b07ac2cdaf26eecc3bf224bb
Cr-Commit-Position: refs/heads/master@{#409709}
==========

[commit-bot: I haz the power, 2016-08-04 02:45:13]

Patchset 2 (id:??) landed as
https://crrev.com/7d02278211e46de5b07ac2cdaf26eecc3bf224bb
Cr-Commit-Position: refs/heads/master@{#409709}