MD Settings: Associate suppages with the controls that trigger them.

MD Settings: Associate suppages with the controls that trigger them.

This is necessary such that when a search hit is found in a subpage the
associated control can be properly highlighted to guide the user to the search
hit.

BUG=633657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca4931526f851d5eb74bcb22b85af36a260f12c2
Cr-Commit-Position: refs/heads/master@{#409977}

[dpapad, 2016-08-03 17:39:37]

Description was changed from

==========
MD Settings: Associate suppages with the controls that trigger them.

This is necessary such that when a search hit is found in a subpage the
associated control can be properly highlighted to guide the user to the search
hit.

BUG=633657
==========

to

==========
MD Settings: Associate suppages with the controls that trigger them.

This is necessary such that when a search hit is found in a subpage the
associated control can be properly highlighted to guide the user to the search
hit.

BUG=633657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-08-03 17:41:04]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-08-04 01:20:03]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-08-04 01:20:04]

There are still some site settings related <setting-subpage> instances that do
not have an associated control specified, because the control that triggers a
subpage is not even in the same HTML file, so have not figured out how to
associate them yet. For example

Controls to open site-settings subpages are at
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...

But the subpages themselves are not in site_settings_page.html, which is odd.
Instead they are declared in privacy_page.html
(https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/privac...).

I might have to move all settings subpages under <settigs-site-settings-page> in
follow up CL. This is still a very good start, since it will cause search
bubbles to show up for most non site-settings related subpages.

[Dan Beam, 2016-08-04 05:01:59]

can we add no-associated-control on site-settings and otherwise assert() these
selectors are right?

[dpapad, 2016-08-04 21:05:32]

Patchset #3 (id:60001) has been deleted

[dpapad, 2016-08-04 21:11:37]

Patchset #3 (id:80001) has been deleted

[dpapad, 2016-08-04 21:17:17]

On 2016/08/04 at 05:01:59, dbeam wrote:
> can we add no-associated-control on site-settings and otherwise assert() these
selectors are right?

Done. Added no-associated-control in every settings-subpage that does not have
an associated control. The assertion is happening in the next CL
https://codereview.chromium.org/2202723004.

[Dan Beam, 2016-08-04 23:57:42]

lgtm

https://codereview.chromium.org/2210583002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_page/settings_subpage.js
(right):

https://codereview.chromium.org/2210583002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_page/settings_subpage.js:34:
associatedControl: Object,
should this be value: null by default, then?

[dpapad, 2016-08-05 00:03:14]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-08-05 00:03:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2210583002/#ps120001
(title: "Nit.")

[dpapad, 2016-08-05 00:03:27]

https://codereview.chromium.org/2210583002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_page/settings_subpage.js
(right):

https://codereview.chromium.org/2210583002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_page/settings_subpage.js:34:
associatedControl: Object,
On 2016/08/04 at 23:57:42, Dan Beam wrote:
> should this be value: null by default, then?

Done.

[commit-bot: I haz the power, 2016-08-05 00:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:06:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2016-08-05 00:55:24]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-08-05 00:55:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2210583002/#ps140001
(title: "Resolve conflicts with ToT")

[commit-bot: I haz the power, 2016-08-05 00:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 03:06:51]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-08-05 03:09:25]

Description was changed from

==========
MD Settings: Associate suppages with the controls that trigger them.

This is necessary such that when a search hit is found in a subpage the
associated control can be properly highlighted to guide the user to the search
hit.

BUG=633657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Associate suppages with the controls that trigger them.

This is necessary such that when a search hit is found in a subpage the
associated control can be properly highlighted to guide the user to the search
hit.

BUG=633657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca4931526f851d5eb74bcb22b85af36a260f12c2
Cr-Commit-Position: refs/heads/master@{#409977}
==========

[commit-bot: I haz the power, 2016-08-05 03:09:26]

Patchset 5 (id:??) landed as
https://crrev.com/ca4931526f851d5eb74bcb22b85af36a260f12c2
Cr-Commit-Position: refs/heads/master@{#409977}