chrome/browser/resources/settings/search_page/search_page.html - Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve conflicts with ToT Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_page/search_page.html

diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html

index cc4f0495dea4bdf8f3cbb6fc6113bb5d9df0b901..98aa02e4085b1869b23c9c517c7570c75e10e2f1 100644

--- a/chrome/browser/resources/settings/search_page/search_page.html

+++ b/chrome/browser/resources/settings/search_page/search_page.html

@@ -31,7 +31,7 @@

</paper-listbox>

</paper-dropdown-menu>

</div>

- <div class="settings-box">

+ <div id="subpage-trigger" class="settings-box">

<paper-button on-tap="onManageSearchEnginesTap_"

class="primary-button">

$i18n{searchEnginesManage}

@@ -39,7 +39,9 @@

</div>

</neon-animatable>

- <settings-subpage page-title="$i18n{searchEnginesManage}">

+ <settings-subpage

+ associated-control="[[$$('#subpage-trigger')]]"

+ page-title="$i18n{searchEnginesManage}">

<settings-search-engines-page></settings-search-engines-page>

</settings-subpage>

</template>