Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve conflicts with ToT Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 722ddb707ecb07d8c38ed5376a9f3934a55834e5..d3c1f935b7153ecd0bf37dd46986776cf5db9063 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -36,7 +36,8 @@
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="languages">
<neon-animatable id="main">
- <div class="settings-box first two-line">
+ <div id="manage-languages-subpage-trigger"
+ class="settings-box first two-line">
<div class="start">
<div>$i18n{languagesListTitle}</div>
<div class="secondary">
@@ -110,7 +111,8 @@
</div>
</iron-collapse>
<if expr="chromeos">
- <div class="settings-box two-line">
+ <div id="manage-input-methods-subpage-trigger"
+ class="settings-box two-line">
<div class="start">
<div>$i18n{inputMethodsListTitle}</div>
<div class="secondary">
@@ -149,7 +151,7 @@
</iron-collapse>
</if>
<if expr="not is_macosx">
- <div class="settings-box two-line">
+ <div id="spellcheck-subpage-trigger" class="settings-box two-line">
<div class="start">
<div>$i18n{spellCheckListTitle}</div>
<div class="secondary">
@@ -186,13 +188,15 @@
</if>
</neon-animatable>
<template is="dom-if" name="manage-languages">
- <settings-subpage page-title="$i18n{manageLanguagesPageTitle}">
+ <settings-subpage
+ associated-control="[[$$('#manage-languages-subpage-trigger')]]"
+ page-title="$i18n{manageLanguagesPageTitle}">
<settings-manage-languages-page
prefs="{{prefs}}"></settings-manage-languages-page>
</settings-subpage>
</template>
<template is="dom-if" name="language-detail">
- <settings-subpage
+ <settings-subpage no-associated-control
page-title="[[detailLanguage_.language.displayName]]">
<settings-language-detail-page id="languageDetailPage"
prefs="{{prefs}}" detail="[[detailLanguage_]]">
@@ -201,7 +205,9 @@
</template>
<if expr="chromeos">
<template is="dom-if" name="manage-input-methods">
- <settings-subpage page-title="$i18n{manageInputMethodsPageTitle}">
+ <settings-subpage
+ associated-control="[[$$('#manage-input-methods-subpage-trigger')]]"
+ page-title="$i18n{manageInputMethodsPageTitle}">
<settings-manage-input-methods-page>
</settings-manage-input-methods-page>
</settings-subpage>
@@ -209,7 +215,9 @@
</if>
<if expr="not is_macosx">
<template is="dom-if" name="edit-dictionary">
- <settings-subpage page-title="$i18n{editDictionaryPageTitle}">
+ <settings-subpage
+ associated-control="[[$$('#spellcheck-subpage-trigger')]]"
+ page-title="$i18n{editDictionaryPageTitle}">
<settings-edit-dictionary-page></settings-edit-dictionary-page>
</settings-subpage>
</template>

Powered by Google App Engine
This is Rietveld 408576698