Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2209833002: Gsutil ls misses should not be treated as failures by bisect. (Closed)

Created:
4 years, 4 months ago by RobertoCN
Modified:
4 years, 4 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Gsutil ls misses should not be treated as failures by bisect. The purpose of this is to declutter bisect output. The gsutil module calls a wrapper that contains retry logic to avoid cases of flake. Actual failures of gsutil remain a possibility, and this change would make it a little tricky to diagnose since we won't have purple steps, but in this case all that will happen is that builds will either time out or the download and unzip step would fail. Google Storage going down has not as of yet been a problem for bisect. R=sullivan,dtu@chromium.org BUG=634045 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e5316b18800771931a523593991755d5a978f840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 6 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
RobertoCN
4 years, 4 months ago (2016-08-03 18:18:22 UTC) #1
sullivan
This makes sense to me, but can you explain at a high level if this ...
4 years, 4 months ago (2016-08-03 18:53:11 UTC) #2
RobertoCN
Updated CL description PTAL
4 years, 4 months ago (2016-08-10 18:12:45 UTC) #5
sullivan
lgtm
4 years, 4 months ago (2016-08-10 18:31:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209833002/1
4 years, 4 months ago (2016-08-10 19:14:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:17:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e5316b18800771931a52...

Powered by Google App Engine
This is Rietveld 408576698