Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2209833002: Gsutil ls misses should not be treated as failures by bisect. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/api.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py
index f77ca715e59a2093a9da2b8594207623932c1189..d914e5ce14bf525608f31503beed36229d5e3b9d 100644
--- a/scripts/slave/recipe_modules/auto_bisect/api.py
+++ b/scripts/slave/recipe_modules/auto_bisect/api.py
@@ -99,6 +99,9 @@ class AutoBisectApi(recipe_api.RecipeApi):
try:
self.m.gsutil(['ls', path])
except self.m.step.StepFailure: # pragma: no cover
+ # A step failure here simply means that the file does not exist, and
+ # should not be treated as an error.
+ self.m.step.active_result.presentation.status = self.m.step.SUCCESS
return False
return True
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698