Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2209833002: Gsutil ls misses should not be treated as failures by bisect. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """API for the bisect recipe module. 5 """API for the bisect recipe module.
6 6
7 This API is meant to enable the bisect recipe to bisect any chromium-supported 7 This API is meant to enable the bisect recipe to bisect any chromium-supported
8 platform for any test that can be run via buildbot, perf or otherwise. 8 platform for any test that can be run via buildbot, perf or otherwise.
9 """ 9 """
10 10
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 def set_svn_repo(self, svn_repo_url): # pragma: no cover 93 def set_svn_repo(self, svn_repo_url): # pragma: no cover
94 """Sets SVN repo url for triggering build jobs.""" 94 """Sets SVN repo url for triggering build jobs."""
95 self.svn_repo_url = svn_repo_url 95 self.svn_repo_url = svn_repo_url
96 96
97 def gsutil_file_exists(self, path): 97 def gsutil_file_exists(self, path):
98 """Returns True if a file exists at the given GS path.""" 98 """Returns True if a file exists at the given GS path."""
99 try: 99 try:
100 self.m.gsutil(['ls', path]) 100 self.m.gsutil(['ls', path])
101 except self.m.step.StepFailure: # pragma: no cover 101 except self.m.step.StepFailure: # pragma: no cover
102 # A step failure here simply means that the file does not exist, and
103 # should not be treated as an error.
104 self.m.step.active_result.presentation.status = self.m.step.SUCCESS
102 return False 105 return False
103 return True 106 return True
104 107
105 def query_revision_info(self, revision): 108 def query_revision_info(self, revision):
106 """Gathers information on a particular revision. 109 """Gathers information on a particular revision.
107 110
108 Args: 111 Args:
109 revision (str): A git commit hash. 112 revision (str): A git commit hash.
110 113
111 Returns: 114 Returns:
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 affected_files, update_step, self.bot_db) 391 affected_files, update_step, self.bot_db)
389 finally: 392 finally:
390 if api.chromium.c.TARGET_PLATFORM == 'android': 393 if api.chromium.c.TARGET_PLATFORM == 'android':
391 if self.internal_bisect: # pragma: no cover 394 if self.internal_bisect: # pragma: no cover
392 api.chromium_android.init_and_sync( 395 api.chromium_android.init_and_sync(
393 gclient_config=api.chromium_android.c.internal_dir_name, 396 gclient_config=api.chromium_android.c.internal_dir_name,
394 use_bot_update=True) 397 use_bot_update=True)
395 else: 398 else:
396 api.bot_update.ensure_checkout() 399 api.bot_update.ensure_checkout()
397 api.chromium_android.common_tests_final_steps() 400 api.chromium_android.common_tests_final_steps()
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698