third_party/WebKit/Source/core/html/forms/InputTypeView.cpp - Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add parseAttribute back to pass one more test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input.html ('K') | « third_party/WebKit/Source/core/html/forms/InputTypeView.h ('k') | third_party/WebKit/Source/core/html/forms/RangeInputType.h » ('j') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

index a9d4dfdfb8a6d11fb852f4ab620dd4a511050980..56ae7dacf642cba036450f499d7b2d9c8d632382 100644

--- a/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

+++ b/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

@@ -75,10 +75,6 @@ void InputTypeView::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*)

{

}

-void InputTypeView::handleTouchEvent(TouchEvent*)

void InputTypeView::handleDOMActivateEvent(Event*)

{

}

@@ -226,11 +222,6 @@ void InputTypeView::subtreeHasChanged()

NOTREACHED();

}

-bool InputTypeView::hasTouchEventHandler() const

- return false;

void InputTypeView::listAttributeTargetChanged()

{

}