third_party/WebKit/Source/core/html/forms/InputTypeView.h - Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputTypeView.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add parseAttribute back to pass one more test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input.html ('K') | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputTypeView.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/InputTypeView.h

diff --git a/third_party/WebKit/Source/core/html/forms/InputTypeView.h b/third_party/WebKit/Source/core/html/forms/InputTypeView.h

index 572f4647299ed20759706bcdb088547338f3fd82..1a45eaf5d709c4c009304d903400f6c7717ee357 100644

--- a/third_party/WebKit/Source/core/html/forms/InputTypeView.h

+++ b/third_party/WebKit/Source/core/html/forms/InputTypeView.h

@@ -55,7 +55,6 @@ class KeyboardEvent;

class MouseEvent;

class LayoutObject;

class ComputedStyle;

-class TouchEvent;

class ClickHandlingState final : public EventDispatchHandlingState {

public:

@@ -87,7 +86,6 @@ public:

virtual void handleKeypressEvent(KeyboardEvent*);

virtual void handleKeyupEvent(KeyboardEvent*);

virtual void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*);

- virtual void handleTouchEvent(TouchEvent*);

virtual void forwardEvent(Event*);

virtual bool shouldSubmitImplicitly(Event*);

virtual HTMLFormElement* formForSubmission() const;

@@ -97,7 +95,6 @@ public:

virtual void handleBlurEvent();

virtual void handleDOMActivateEvent(Event*);

virtual void accessKeyAction(bool sendMouseEvents);

- virtual bool hasTouchEventHandler() const;

virtual void blur();

void dispatchSimulatedClickIfActive(KeyboardEvent*) const;