third_party/WebKit/Source/core/html/forms/RangeInputType.h - Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add parseAttribute back to pass one more test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input.html ('K') | « third_party/WebKit/Source/core/html/forms/InputTypeView.cpp ('k') | third_party/WebKit/Source/core/html/forms/RangeInputType.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.h b/third_party/WebKit/Source/core/html/forms/RangeInputType.h

index e18c911b34c2fa57ce3ff9d94caa41cb5a7c7e7f..2e6393c6642f3830f9249668b18a2c80828e523d 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.h

@@ -59,8 +59,6 @@ private:

StepRange createStepRange(AnyStepHandling) const override;

bool isSteppable() const override;

void handleMouseDownEvent(MouseEvent*) override;

- void handleTouchEvent(TouchEvent*) override;

- bool hasTouchEventHandler() const override;

void handleKeydownEvent(KeyboardEvent*) override;

LayoutObject* createLayoutObject(const ComputedStyle&) const override;

void createShadowSubtree() override;