DescriptionRevert of Enable whitelist generation for all builds. (patchset #5 id:80001 of https://codereview.chromium.org/2175413004/ )
Reason for revert:
Breaks internal Chrome OS builds.
Original issue's description:
> Enable whitelist generation for official builds.
>
> Currently, all resources are included in PAK files when Chrome is
> built locally. Only official_buildbot.sh uses a resource whitelist. This CL
> enables local builds to use resource whitelisting by setting the
> enable_resource_whitelist_generation gn flag to true, or by building an
> official build.
>
> This will allow developers to more easily monitor the changes in APK size
> for each commit they make.
>
> However, a large amount of output is generated (_pragma is used to
> create warnings to allow whitelisted resources to be listed), so for now
> the whitelist will only be generated for official builds.
>
> Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
> * Local build with this patch: 73338275 bytes
> * Local build without this patch: 75248223 bytes
>
> BUG=632385
>
> Committed: https://crrev.com/3f3fa5fc415baab5a875839e6520c2cbb245ec38
> Cr-Commit-Position: refs/heads/master@{#409511}
TBR=agrieve@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632385
Committed: https://crrev.com/d44cdb8d3daf1c6e57fbdb8abfd3212154cbf6f4
Cr-Commit-Position: refs/heads/master@{#409547}
Patch Set 1 #
Messages
Total messages: 13 (5 generated)
|