Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issue 2209763002: Revert of Enable whitelist generation for all builds. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable whitelist generation for all builds. (patchset #5 id:80001 of https://codereview.chromium.org/2175413004/ ) Reason for revert: Breaks internal Chrome OS builds. Original issue's description: > Enable whitelist generation for official builds. > > Currently, all resources are included in PAK files when Chrome is > built locally. Only official_buildbot.sh uses a resource whitelist. This CL > enables local builds to use resource whitelisting by setting the > enable_resource_whitelist_generation gn flag to true, or by building an > official build. > > This will allow developers to more easily monitor the changes in APK size > for each commit they make. > > However, a large amount of output is generated (_pragma is used to > create warnings to allow whitelisted resources to be listed), so for now > the whitelist will only be generated for official builds. > > Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py: > * Local build with this patch: 73338275 bytes > * Local build without this patch: 75248223 bytes > > BUG=632385 > > Committed: https://crrev.com/3f3fa5fc415baab5a875839e6520c2cbb245ec38 > Cr-Commit-Position: refs/heads/master@{#409511} TBR=agrieve@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632385 Committed: https://crrev.com/d44cdb8d3daf1c6e57fbdb8abfd3212154cbf6f4 Cr-Commit-Position: refs/heads/master@{#409547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -366 lines) Patch
M build/toolchain/gcc_ar_wrapper.py View 3 chunks +15 lines, -10 lines 0 comments Download
D build/toolchain/gcc_compile_wrapper.py View 1 chunk +0 lines, -44 lines 0 comments Download
M build/toolchain/gcc_solink_wrapper.py View 5 chunks +21 lines, -16 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 6 chunks +2 lines, -33 lines 0 comments Download
D build/toolchain/wrapper_utils.py View 1 chunk +0 lines, -105 lines 0 comments Download
M chrome/BUILD.gn View 4 chunks +0 lines, -41 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 4 chunks +5 lines, -12 lines 0 comments Download
M tools/grit/grit/format/repack.py View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +3 lines, -7 lines 0 comments Download
M tools/grit/repack.gni View 2 chunks +10 lines, -6 lines 0 comments Download
A tools/resources/find_used_resources.py View 1 chunk +89 lines, -0 lines 0 comments Download
D tools/resources/generate_resource_whitelist.py View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
estevenson
Created Revert of Enable whitelist generation for all builds.
4 years, 4 months ago (2016-08-03 16:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209763002/1
4 years, 4 months ago (2016-08-03 17:00:29 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-03 17:00:31 UTC) #5
stevenjb
lgtm
4 years, 4 months ago (2016-08-03 17:06:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209763002/1
4 years, 4 months ago (2016-08-03 17:07:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 17:08:25 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d44cdb8d3daf1c6e57fbdb8abfd3212154cbf6f4 Cr-Commit-Position: refs/heads/master@{#409547}
4 years, 4 months ago (2016-08-03 17:09:58 UTC) #12
Dirk Pranke
4 years, 4 months ago (2016-08-03 17:41:42 UTC) #13
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698