Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Side by Side Diff: chrome/chrome_repack_locales.gni

Issue 2209763002: Revert of Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | tools/grit/grit/format/data_pack.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//tools/grit/repack.gni") 8 import("//tools/grit/repack.gni")
9 import("//tools/grit/grit_rule.gni")
10 9
11 # Arguments: 10 # Arguments:
12 # 11 #
13 # locale 12 # locale
14 # Internal name of locale. e.g. "pt-BR" 13 # Internal name of locale. e.g. "pt-BR"
15 # 14 #
16 # output 15 # output
17 # Output file name. 16 # Output file name.
18 # 17 #
19 # visibility 18 # visibility
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 sources += [ 111 sources += [
113 "${root_gen_dir}/chrome/chromium_strings_${locale}.pak", 112 "${root_gen_dir}/chrome/chromium_strings_${locale}.pak",
114 "${root_gen_dir}/components/strings/components_chromium_strings_${locale }.pak", 113 "${root_gen_dir}/components/strings/components_chromium_strings_${locale }.pak",
115 ] 114 ]
116 deps += [ 115 deps += [
117 "//chrome/app:chromium_strings", 116 "//chrome/app:chromium_strings",
118 "//components/strings:components_chromium_strings", 117 "//components/strings:components_chromium_strings",
119 ] 118 ]
120 } 119 }
121 120
122 if (enable_resource_whitelist_generation) {
123 repack_whitelist = "$target_gen_dir/resource_whitelist.txt"
124 deps += [ "//chrome:resource_whitelist" ]
125 }
126 output = invoker.output 121 output = invoker.output
127 } 122 }
128 } 123 }
129 124
130 # Creates an action to call the repack_locales script. 125 # Creates an action to call the repack_locales script.
131 # 126 #
132 # The GYP version generates the locales in the "gen" directory and then copies 127 # The GYP version generates the locales in the "gen" directory and then copies
133 # it to the root build directory. This isn't easy to express in a GN copy 128 # it to the root build directory. This isn't easy to express in a GN copy
134 # rule since the files on Mac have a complex structure. So we generate the 129 # rule since the files on Mac have a complex structure. So we generate the
135 # files into the final place and skip the "gen" directory. 130 # files into the final place and skip the "gen" directory.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 197
203 current_index = current_index + 1 198 current_index = current_index + 1
204 } 199 }
205 200
206 # The group that external targets depend on which collects all deps. 201 # The group that external targets depend on which collects all deps.
207 group(group_target_name) { 202 group(group_target_name) {
208 forward_variables_from(invoker, [ "visibility" ]) 203 forward_variables_from(invoker, [ "visibility" ])
209 public_deps = locale_targets 204 public_deps = locale_targets
210 } 205 }
211 } 206 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | tools/grit/grit/format/data_pack.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698