Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2209763002: Revert of Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_solink_wrapper.py ('k') | build/toolchain/wrapper_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/gcc_toolchain.gni
diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni
index 188c8f1fdfe018776f555ff9b06bea90e879891e..4cdd0461aa9851b0cb4f1eade6532c77814d3b5f 100644
--- a/build/toolchain/gcc_toolchain.gni
+++ b/build/toolchain/gcc_toolchain.gni
@@ -10,7 +10,6 @@
import("//build/toolchain/goma.gni")
import("//build/toolchain/toolchain.gni")
import("//build/toolchain/concurrent_links.gni")
-import("//tools/grit/grit_rule.gni")
# This template defines a toolchain for something that works like gcc
# (including clang).
@@ -224,41 +223,23 @@
object_subdir = "{{target_out_dir}}/{{label_name}}"
tool("cc") {
- whitelist_flag = " "
- if (enable_resource_whitelist_generation) {
- whitelist_flag = " --resource-whitelist=\"{{output}}.whitelist\""
- }
depfile = "{{output}}.d"
command = "$cc -MMD -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{cflags}} {{cflags_c}}${extra_cppflags}${extra_cflags} -c {{source}} -o {{output}}"
depsformat = "gcc"
description = "CC {{output}}"
outputs = [
- # The whitelist file is also an output, but ninja does not
- # currently support multiple outputs for tool("cc").
"$object_subdir/{{source_name_part}}.o",
]
- compile_wrapper = rebase_path("//build/toolchain/gcc_compile_wrapper.py",
- root_build_dir)
- command = "$python_path \"$compile_wrapper\"$whitelist_flag $command"
}
tool("cxx") {
- whitelist_flag = " "
- if (enable_resource_whitelist_generation) {
- whitelist_flag = " --resource-whitelist=\"{{output}}.whitelist\""
- }
depfile = "{{output}}.d"
command = "$cxx -MMD -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{cflags}} {{cflags_cc}}${extra_cppflags}${extra_cxxflags} -c {{source}} -o {{output}}"
depsformat = "gcc"
description = "CXX {{output}}"
outputs = [
- # The whitelist file is also an output, but ninja does not
- # currently support multiple outputs for tool("cxx").
"$object_subdir/{{source_name_part}}.o",
]
- compile_wrapper = rebase_path("//build/toolchain/gcc_compile_wrapper.py",
- root_build_dir)
- command = "$python_path \"$compile_wrapper\"$whitelist_flag $command"
}
tool("asm") {
@@ -274,17 +255,13 @@
tool("alink") {
rspfile = "{{output}}.rsp"
- whitelist_flag = " "
- if (enable_resource_whitelist_generation) {
- whitelist_flag = " --resource-whitelist=\"{{output}}.whitelist\""
- }
# This needs a Python script to avoid using simple sh features in this
# command, in case the host does not use a POSIX shell (e.g. compiling
# POSIX-like toolchains such as NaCl on Windows).
ar_wrapper =
rebase_path("//build/toolchain/gcc_ar_wrapper.py", root_build_dir)
- command = "$python_path \"$ar_wrapper\"$whitelist_flag --output={{output}} --ar=\"$ar\" {{arflags}} rcsD @\"$rspfile\""
+ command = "$python_path \"$ar_wrapper\" --output={{output}} --ar=\"$ar\" {{arflags}} rcsD @\"$rspfile\""
description = "AR {{output}}"
rspfile_content = "{{inputs}}"
outputs = [
@@ -302,11 +279,6 @@
soname = "{{target_output_name}}{{output_extension}}" # e.g. "libfoo.so".
sofile = "{{output_dir}}/$soname" # Possibly including toolchain dir.
rspfile = sofile + ".rsp"
- whitelist_flag = " "
- if (enable_resource_whitelist_generation) {
- whitelist_file = "$sofile.whitelist"
- whitelist_flag = " --resource-whitelist=\"$whitelist_file\""
- }
if (defined(invoker.strip)) {
unstripped_sofile = "{{root_out_dir}}/lib.unstripped/$soname"
@@ -333,7 +305,7 @@
# requiring sh control structures, pipelines, and POSIX utilities.
# The host might not have a POSIX shell and utilities (e.g. Windows).
solink_wrapper = rebase_path("//build/toolchain/gcc_solink_wrapper.py")
- command = "$python_path \"$solink_wrapper\" --readelf=\"$readelf\" --nm=\"$nm\" $strip_switch --sofile=\"$unstripped_sofile\" --tocfile=\"$tocfile\" --output=\"$sofile\"$whitelist_flag -- $link_command"
+ command = "$python_path \"$solink_wrapper\" --readelf=\"$readelf\" --nm=\"$nm\" $strip_switch --sofile=\"$unstripped_sofile\" --tocfile=\"$tocfile\" --output=\"$sofile\" -- $link_command"
rspfile_content = "-Wl,--whole-archive {{inputs}} {{solibs}} -Wl,--no-whole-archive $solink_libs_section_prefix {{libs}} $solink_libs_section_postfix"
@@ -362,9 +334,6 @@
sofile,
tocfile,
]
- if (enable_resource_whitelist_generation) {
- outputs += [ whitelist_file ]
- }
if (sofile != unstripped_sofile) {
outputs += [ unstripped_sofile ]
}
« no previous file with comments | « build/toolchain/gcc_solink_wrapper.py ('k') | build/toolchain/wrapper_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698