Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2209713002:
Fix compilation with Xcode version of clang. (Closed)
DescriptionFix compilation with Xcode version of clang.
Fix unused variable error in //build/toolchain/mac/BUILD.gn by
moving the _compiler_prefix variable inside the mac_toolchain
template.
Only check the use_clang_xcode variable for the default toolchain
as some file are build with "mac" current_os on iOS.
BUG=633978
Committed: https://crrev.com/ecc33473f3dbebda070e0ceedb9316591414949f
Cr-Commit-Position: refs/heads/master@{#409570}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Change conditional. #
Messages
Total messages: 22 (10 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look and send to CQ if lgty.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2209713002/diff/1/build/toolchain/toolchain.gni File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2209713002/diff/1/build/toolchain/toolchain.g... build/toolchain/toolchain.gni:55: } This is probably relatively harmless (or even a good thing), but unless we explicitly set use_xcode_clang=false in toolchain_args(), we'll probably end up using xcode clang for host binaries as well. So, this might be a bit clearer if the assert was (!use_xcode_clang || target_os=="ios").
lgtm
https://codereview.chromium.org/2209713002/diff/1/build/toolchain/toolchain.gni File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2209713002/diff/1/build/toolchain/toolchain.g... build/toolchain/toolchain.gni:55: } On 2016/08/03 16:49:50, Dirk Pranke wrote: > This is probably relatively harmless (or even a good thing), but unless we > explicitly set use_xcode_clang=false in toolchain_args(), we'll probably end up > using xcode clang for host binaries as well. > > So, this might be a bit clearer if the assert was (!use_xcode_clang || > target_os=="ios"). The changes in build/toolchain/mac/BUILD.gn only check use_xcode_clang if toolchain_os is "ios", so when building for iOS, we use the hermetic version of clang for host_toolchain and xcode's clang for target toolchains. I've changed the conditional as I agree it is cleaner.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2209713002/#ps20001 (title: "Change conditional.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Ah, right. I wonder if we should maybe even allow xcode_clang to be used for mac builds? cc'ing some mac folks to see if they have opinions.
On 2016/08/03 17:41:02, Dirk Pranke wrote: > Ah, right. > > I wonder if we should maybe even allow xcode_clang to be used for mac builds? I thought I had disallowed that in https://codereview.chromium.org/2129603002/ . Did that not work?
On 2016/08/03 17:41:02, Dirk Pranke wrote: > Ah, right. > > I wonder if we should maybe even allow xcode_clang to be used for mac builds? > > cc'ing some mac folks to see if they have opinions. No, I don't think we should support building with Xcode clang on Mac.
On 2016/08/03 17:41:02, Dirk Pranke wrote: > Ah, right. > > I wonder if we should maybe even allow xcode_clang to be used for mac builds? > > cc'ing some mac folks to see if they have opinions. Ah, I read the question the wrong way. No, I don't think we should allow that. This change lgtm, thanks for fixing my bugs!
Alrighty then. I suppose we can always hand-enable it if we need to test something.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix compilation with Xcode version of clang. Fix unused variable error in //build/toolchain/mac/BUILD.gn by moving the _compiler_prefix variable inside the mac_toolchain template. Only check the use_clang_xcode variable for the default toolchain as some file are build with "mac" current_os on iOS. BUG=633978 ========== to ========== Fix compilation with Xcode version of clang. Fix unused variable error in //build/toolchain/mac/BUILD.gn by moving the _compiler_prefix variable inside the mac_toolchain template. Only check the use_clang_xcode variable for the default toolchain as some file are build with "mac" current_os on iOS. BUG=633978 Committed: https://crrev.com/ecc33473f3dbebda070e0ceedb9316591414949f Cr-Commit-Position: refs/heads/master@{#409570} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ecc33473f3dbebda070e0ceedb9316591414949f Cr-Commit-Position: refs/heads/master@{#409570} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
